From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751413AbeACGl0 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 3 Jan 2018 01:41:26 -0500
Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:56573 "EHLO
        SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org
        with ESMTP id S1750766AbeACGlZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Jan 2018 01:41:25 -0500
Date: Wed, 3 Jan 2018 14:32:52 +0800
From: Erick Chen <erick.chen@spreadtrum.com>
To: Axel Lin <axel.lin@ingics.com>
CC: Mark Brown <broonie@kernel.org>,
        Baolin Wang <baolin.wang@spreadtrum.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK
 and SC2731_PWR_WR_PROT_VALUE
Message-ID: <20180103063251.GA16439@spreadtrum.com>
References: <20180101123850.21936-1-axel.lin@ingics.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180101123850.21936-1-axel.lin@ingics.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MAIL: SHSQR01.spreadtrum.com w036dCHE081490
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Hi Axel,

On 一,  1月 01, 2018 at 08:38:50下午 +0800, Axel Lin wrote:
> The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes
> regmap_write() call looks strange because it takes reg parameter fist
> then val.
> Base on Erick's suggestion to define SC2731_PWR_WR_PROT and
> SC2731_WR_UNLOCK_VALUE instead.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Reviewed-by: Erick Chen <erick.chen@spreadtrum.com>

>