From: Stephen Hemminger <stephen@networkplumber.org>
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org
Subject: Re: [PATCH 1/2] mlx5: don't pass unused argument to sub-functions
Date: Wed, 3 Jan 2018 07:21:58 -0800 [thread overview]
Message-ID: <20180103072158.4084e5d3@xeon-e3> (raw)
In-Reply-To: <20180103073523.ooc6ctimzxkayqci@laranjeiro-vm.dev.6wind.com>
On Wed, 3 Jan 2018 08:35:23 +0100
Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
> Hi Stephen,
>
> On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote:
> > Since wait_to_complete is unused, don't pass it to helper functions.
> > Use the standard RTE macro to indicate this is an unused parameter.
>
> I would suggest to use the (void) as it is done in the whole driver, a
> specific patch should be done to use the rte_unused macro in all the
> sources at once.
>
> Thanks,
>
There is a standard in DPDK using RTE macros. The whole driver should
follow that rather than trying to be different.
next prev parent reply other threads:[~2018-01-03 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 20:53 [PATCH 0/2] mlx5: remove dependency on kernel version Stephen Hemminger
2018-01-02 20:53 ` [PATCH 1/2] mlx5: don't pass unused argument to sub-functions Stephen Hemminger
2018-01-03 7:35 ` Nelio Laranjeiro
2018-01-03 15:21 ` Stephen Hemminger [this message]
2018-01-04 8:52 ` Nelio Laranjeiro
2018-01-02 20:53 ` [PATCH 2/2] mlx5: don't depend on kernel version Stephen Hemminger
2018-01-03 7:33 ` Nelio Laranjeiro
2018-01-03 10:25 ` [PATCH 0/2] mlx5: remove dependency " Nelio Laranjeiro
2018-01-03 15:21 ` Stephen Hemminger
2018-01-04 8:49 ` Nelio Laranjeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103072158.4084e5d3@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.