From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Erez Shitrit <erezsh-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
RDMA mailing list
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages
Date: Wed, 3 Jan 2018 09:06:48 -0700 [thread overview]
Message-ID: <20180103160648.GD11348@ziepe.ca> (raw)
In-Reply-To: <CAAk-MO_ArzS5irkN-_nt_YYL3+YgL+FpM6WLvPZfM-mKexsShg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Jan 03, 2018 at 11:33:05AM +0200, Erez Shitrit wrote:
> On Tue, Jan 2, 2018 at 11:24 PM, Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
> > On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote:
> >> If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
> >> it may return positive value indicating non-empty CQ.
> >> If return code not verified the log might be flooded with false
> >> warning messages "request notify on send CQ failed".
> >>
> >> Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
> >
> > Hurm... It was right before that commit as well..
> >
> > Erez, why did you change it?
>
> I don't think i changed it.
Okay, then it is a typo when you reworked things for NAPI that the >0
case started making warnings. I will apply this patch.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-03 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 21:04 [PATCH] IB/ipoib: Fix for notify send CQ failure messages Alex Estrin
[not found] ` <20180102210419.26104.32513.stgit-u2TXY/5TJkdZ7WVY1cDZ9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
2018-01-02 21:24 ` Jason Gunthorpe
[not found] ` <20180102212407.GA19027-uk2M96/98Pc@public.gmane.org>
2018-01-03 9:33 ` Erez Shitrit
[not found] ` <CAAk-MO_ArzS5irkN-_nt_YYL3+YgL+FpM6WLvPZfM-mKexsShg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 16:06 ` Jason Gunthorpe [this message]
2018-01-03 12:03 ` Estrin, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103160648.GD11348@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=erezsh-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.