From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: Issue with commit fea23fb591cc "net: phy: convert
 read-modify-write to phy_modify()"
Date: Thu, 4 Jan 2018 13:59:57 +0100
Message-ID: <20180104125957.GH6671@lunn.ch>
References: <8cf4bdaa-bd05-1962-f1d0-6cb84db31588@googlemail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:54126 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752372AbeADNAC (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 4 Jan 2018 08:00:02 -0500
Content-Disposition: inline
In-Reply-To: <8cf4bdaa-bd05-1962-f1d0-6cb84db31588@googlemail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Jan 04, 2018 at 08:00:53AM +0100, Heiner Kallweit wrote:
> Parameter mask of phy_modify() holds the bits to be cleared.
> In the mentioned commit parameter mask seems to be inverted in
> few cases, what IMO is wrong (see example).
> Maybe I miss something, could you please check?

Hi Heiner

mdio reads/writes can be traced via events. Could you log them for
your board, with and without this patch applied. Hopefully the traces
are similar enough that issues like this can be spotted.

Thanks
	Andrew