From: Christoph Hellwig <hch@infradead.org>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>
Cc: konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH] swiotlb: suppress warning when __GFP_NOWARN is set v5
Date: Thu, 4 Jan 2018 05:29:19 -0800 [thread overview]
Message-ID: <20180104132919.GA7213@infradead.org> (raw)
In-Reply-To: <20180104132419.24536-1-christian.koenig@amd.com>
> @@ -713,6 +713,7 @@ void *
> swiotlb_alloc_coherent(struct device *hwdev, size_t size,
> dma_addr_t *dma_handle, gfp_t flags)
> {
> + bool warn = !(flags & __GFP_NOWARN);
This is still wrong. __GFP_NOWARN has no meaning for DMA coherent
allocations, and if a driver expects it to do anything it's doing it
wrong. This needs to check for DMA_ATTR_NO_WARN, and thus get the attrs
passed.
next prev parent reply other threads:[~2018-01-04 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 13:24 [PATCH] swiotlb: suppress warning when __GFP_NOWARN is set v5 Christian König
2018-01-04 13:29 ` Christoph Hellwig [this message]
2018-01-04 13:49 ` Christian König
2018-01-09 19:47 ` Christoph Hellwig
2018-01-09 20:04 ` Konrad Rzeszutek Wilk
2018-01-09 21:12 ` Christoph Hellwig
2018-01-09 21:23 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104132919.GA7213@infradead.org \
--to=hch@infradead.org \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.