From: Greg KH <gregkh@linuxfoundation.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: devel@driverdev.osuosl.org,
syzbot <syzbot+fa2d5f63ee5904a0115a@syzkaller.appspotmail.com>,
tkjos@android.com, syzkaller-bugs@googlegroups.com,
LKML <linux-kernel@vger.kernel.org>,
arve@android.com, maco@android.com, sumit.semwal@linaro.org
Subject: Re: WARNING in ion_ioctl
Date: Thu, 4 Jan 2018 15:24:55 +0100 [thread overview]
Message-ID: <20180104142455.GA11770@kroah.com> (raw)
In-Reply-To: <CACT4Y+YxWctjfEYuGXv6HZysELA4L1B=Qn2-tPNPL_Na=1Bmdw@mail.gmail.com>
On Thu, Jan 04, 2018 at 03:13:01PM +0100, Dmitry Vyukov wrote:
> On Thu, Jan 4, 2018 at 3:06 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Jan 04, 2018 at 05:57:01AM -0800, syzbot wrote:
> >> Hello,
> >>
> >> syzkaller hit the following crash on
> >> 71ee203389f7cb1c1927eab22b95baa01405791c
> >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
> >> compiler: gcc (GCC) 7.1.1 20170620
> >> .config is attached
> >> Raw console output is attached.
> >> C reproducer is attached
> >> syzkaller reproducer is attached. See https://goo.gl/kgGztJ
> >> for information about syzkaller reproducers
> >>
> >>
> >> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> >> Reported-by: syzbot+fa2d5f63ee5904a0115a@syzkaller.appspotmail.com
> >> It will help syzbot understand when the bug is fixed. See footer for
> >> details.
> >> If you forward the report, please keep this part and the footer.
> >>
> >> audit: type=1400 audit(1514734723.062:7): avc: denied { map } for
> >> pid=3502 comm="syzkaller809746" path="/root/syzkaller809746698" dev="sda1"
> >> ino=16481 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023
> >> tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
> >> WARNING: CPU: 0 PID: 3502 at drivers/staging/android/ion/ion-ioctl.c:73
> >> ion_ioctl+0x2db/0x380 drivers/staging/android/ion/ion-ioctl.c:73
> >> Kernel panic - not syncing: panic_on_warn set ...
> >
> > This is to be expected when you pass in a crappy ion ioctl structure.
> >
> > So don't do that :)
> >
> > Yeah, it's a harsh warning, but I think the userspace developers like it
> > to ensure they got their implementation correct.
> >
> > After the warning is thrown, all keeps working just fine.
>
> Hi Greg,
>
> Or, don't do WARNINGs on EINVAL and do pr_warn instead, as useful but
> also enables automated kernel testing with non-tainted reports, which
> is kinda a useful property.
Sure, that would be the sane thing to do, but this is staging android
code, the exact opposite of "sane" at the moment :)
thanks,
greg k-h
next prev parent reply other threads:[~2018-01-04 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 13:57 WARNING in ion_ioctl syzbot
2018-01-04 14:06 ` Greg KH
2018-01-04 14:13 ` Dmitry Vyukov
2018-01-04 14:24 ` Greg KH [this message]
2018-01-07 9:06 ` Dmitry Vyukov
2018-01-04 14:45 ` Dan Carpenter
2018-01-04 19:01 ` Laura Abbott
2018-01-05 9:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104142455.GA11770@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=sumit.semwal@linaro.org \
--cc=syzbot+fa2d5f63ee5904a0115a@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.