All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 2/2] syscalls/migrate_pages03.c: Add new regression test
Date: Thu, 4 Jan 2018 16:30:45 +0100	[thread overview]
Message-ID: <20180104153045.GA25335@rei> (raw)
In-Reply-To: <1515059054-20875-2-git-send-email-yangx.jy@cn.fujitsu.com>

Hi!
> +#include <errno.h>
> +#include <unistd.h>
> +#include <stdlib.h>
> +#if HAVE_NUMA_H
> +#include <numa.h>
> +#endif
> +#if HAVE_NUMAIF_H
> +#include <numaif.h>
> +#endif
> +
> +#include "config.h"

One small nit, the HAVE_NUMA* macros are defined in config.h so they are
defined only after the config.h header is included. I wonder if these
haders are needed to be included here at all, because they were not
included at all.

Also it's customary to use #ifdef instead of #if for autoconf macros.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-01-04 15:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 10:07 [LTP] [PATCH] syscalls/migrate_pages03.c: Add new regression test Xiao Yang
2017-11-30 15:20 ` Cyril Hrubis
2017-12-21 10:03   ` [LTP] [PATCH v2] " Xiao Yang
2017-12-25 10:26     ` Xiao Yang
2017-12-25 10:37   ` xiao yang
2018-01-03 12:04     ` Jan Stancek
2018-01-03 14:38     ` Cyril Hrubis
2018-01-04  9:26       ` [LTP] [PATCH v3 1/2] lib/mem.c: factor out wait_ksmd_full_scan() xiao yang
2018-01-04  9:26         ` [LTP] [PATCH v3 2/2] syscalls/migrate_pages03.c: Add new regression test xiao yang
2018-01-04  9:34         ` [LTP] [PATCH v3 1/2] lib/mem.c: factor out wait_ksmd_full_scan() Xiao Yang
2018-01-04  9:44       ` [LTP] [PATCH v4 " xiao yang
2018-01-04  9:44         ` [LTP] [PATCH v4 2/2] syscalls/migrate_pages03.c: Add new regression test xiao yang
2018-01-04 15:30           ` Cyril Hrubis [this message]
2018-01-05  1:51             ` Xiao Yang
2018-01-05  2:48             ` [LTP] [PATCH v5 1/3] lib/mem.c: factor out wait_ksmd_full_scan() xiao yang
2018-01-05  2:48               ` [LTP] [PATCH v5 2/3] syscalls/migrate_pages*: Small cleanup xiao yang
2018-02-07 16:22                 ` Cyril Hrubis
2018-01-05  2:48               ` [LTP] [PATCH v5 3/3] syscalls/migrate_pages03.c: Add new regression test xiao yang
2018-01-19  1:51                 ` Xiao Yang
2018-02-02  8:11                 ` Xiao Yang
2018-02-06 21:20                   ` Jan Stancek
2018-05-15  8:30                     ` Xiao Yang
2018-05-16  8:48                       ` Jan Stancek
2018-03-20  9:18                 ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180104153045.GA25335@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.