From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix compiling error in libunwind x86
Date: Thu, 4 Jan 2018 15:25:54 -0300 [thread overview]
Message-ID: <20180104182554.GD14721@kernel.org> (raw)
In-Reply-To: <20171206015040.114574-1-wangnan0@huawei.com>
Em Wed, Dec 06, 2017 at 01:50:40AM +0000, Wang Nan escreveu:
> Fix a compiling error:
>
> ...
> CC util/libunwind/x86_32.o
> In file included from util/libunwind/x86_32.c:33:0:
> util/libunwind/../../arch/x86/util/unwind-libunwind.c: In function 'libunwind__x86_reg_id':
> util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: error: 'EINVAL' undeclared (first use in this function)
> return -EINVAL;
> ^
> util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: note: each undeclared identifier is reported only once for each function it appears in
> mv: cannot stat 'util/libunwind/.x86_32.o.tmp': No such file or directory
> make[4]: *** [util/libunwind/x86_32.o] Error 1
> make[3]: *** [util] Error 2
> make[2]: *** [libperf-in.o] Error 2
> make[1]: *** [sub-make] Error 2
> make: *** [all] Error 2
>
> It happens when libunwind-x86 feature is detected.
Thanks, simple enough, applied.
- Arnaldo
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> ---
> tools/perf/arch/x86/util/unwind-libunwind.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c
> index 9c917f8..05920e3 100644
> --- a/tools/perf/arch/x86/util/unwind-libunwind.c
> +++ b/tools/perf/arch/x86/util/unwind-libunwind.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
>
> -#ifndef REMOTE_UNWIND_LIBUNWIND
> #include <errno.h>
> +#ifndef REMOTE_UNWIND_LIBUNWIND
> #include <libunwind.h>
> #include "perf_regs.h"
> #include "../../util/unwind.h"
> --
> 2.10.1
next prev parent reply other threads:[~2018-01-04 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 1:50 [PATCH] perf tools: Fix compiling error in libunwind x86 Wang Nan
2018-01-04 18:25 ` Arnaldo Carvalho de Melo [this message]
2018-01-11 6:20 ` [tip:perf/core] perf tools: Fix compile error with " tip-bot for Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104182554.GD14721@kernel.org \
--to=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.