From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Issue with commit fea23fb591cc "net: phy: convert read-modify-write to phy_modify()"
Date: Fri, 5 Jan 2018 02:44:07 +0200 [thread overview]
Message-ID: <20180105004405.GA20332@khorivan> (raw)
In-Reply-To: <20180104114439.GL28752@n2100.armlinux.org.uk>
+ G.Strashko
The below change also brokes phy connect for am572x..
int genphy_restart_aneg(struct phy_device *phydev)
{
- int ctl = phy_read(phydev, MII_BMCR);
-
- if (ctl < 0)
- return ctl;
-
- ctl |= BMCR_ANENABLE | BMCR_ANRESTART;
-
/* Don't isolate the PHY if we're negotiating */
- ctl &= ~BMCR_ISOLATE;
-
- return phy_write(phydev, MII_BMCR, ctl);
+ return phy_modify(phydev, MII_BMCR, ~BMCR_ISOLATE,
+ BMCR_ANENABLE | BMCR_ANRESTART);
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2018-01-05 0:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 7:00 Issue with commit fea23fb591cc "net: phy: convert read-modify-write to phy_modify()" Heiner Kallweit
2018-01-04 11:44 ` Russell King - ARM Linux
2018-01-04 19:16 ` Heiner Kallweit
2018-01-05 0:44 ` Ivan Khoronzhuk [this message]
2018-01-05 1:02 ` Russell King - ARM Linux
2018-01-04 12:59 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105004405.GA20332@khorivan \
--to=ivan.khoronzhuk@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.