From: Brian Norris <briannorris@chromium.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Heiko Stuebner <heiko@sntech.de>,
Ziyuan Xu <xzy.xu@rock-chips.com>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy
Date: Thu, 4 Jan 2018 18:12:20 -0800 [thread overview]
Message-ID: <20180105021219.GA168398@google.com> (raw)
In-Reply-To: <20180105020749.GA166692@google.com>
On Thu, Jan 04, 2018 at 06:07:51PM -0800, Brian Norris wrote:
> On Tue, Jan 02, 2018 at 10:22:00AM +0800, Shawn Lin wrote:
> > Just use the API instead of open-coding it, no functional change
> > intended.
> >
> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> > ---
Other than my nit comment, looks fine:
Reviewed-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2018-01-05 2:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 2:21 [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming Shawn Lin
2018-01-02 2:21 ` Shawn Lin
[not found] ` <1514859720-151161-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-02 2:22 ` [PATCH 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy Shawn Lin
2018-01-02 2:22 ` Shawn Lin
2018-01-05 2:07 ` Brian Norris
2018-01-05 2:12 ` Brian Norris [this message]
2018-01-05 2:16 ` Brian Norris
2018-01-04 9:10 ` [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming Ziyuan
2018-01-05 1:32 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105021219.GA168398@google.com \
--to=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=xzy.xu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.