Re: [PATCH rdma-next v2 06/14] {net,IB}/mlx5: Manage port association for multiport RoCE

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

On Thu, Jan 04, 2018 at 04:33:34PM -0700, Jason Gunthorpe wrote:
> > +struct mlx5_ib_odp {
> > +	struct ib_odp_caps	caps;
> > +	u64			max_size;
> > +	/*
> > +	 * Sleepable RCU that prevents destruction of MRs while they are still
> > +	 * being used by a page fault handler.
> > +	 */
> > +	struct srcu_struct      mr_srcu;
> > +	u32			null_mkey;
> > +	void			(*sync)(struct mlx5_ib_dev *dev);
> > +};
>
> Well this doesn't belong in here. rebase error or something?

Very strange, this chunk indeed doesn't belong to this series and Daniel
didn't add it too, but I see this mlx5_ib_odp struct above of newly added
mlx5_ib_multiport_info struct in our review system.

In this series, it comes from my rr-cache, but I don't know why it is in
the review system.

We can safely remove it. Do you want me to respin it?

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]