From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [PATCH] ethdev: fix link autonegotiation value
Date: Fri, 5 Jan 2018 12:47:07 -0800 [thread overview]
Message-ID: <20180105124707.602256c5@xeon-e3> (raw)
In-Reply-To: <20180105173855.25473-1-thomas@monjalon.net>
On Fri, 5 Jan 2018 18:38:55 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> There are 3 kind of link data in ethdev:
> - capabilities (rte_eth_dev_info)
> - configuration (rte_eth_conf)
> - status (rte_eth_link)
>
> A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and
> configuration (rte_eth_conf.link_speeds).
> Bits are defined in ETH_LINK_SPEED_*.
>
> Some numerical (ETH_SPEED_NUM_*) and boolean (ETH_LINK_*) values
> are used for the link status (rte_eth_link.*).
>
> There was a mistake in the comment of rte_eth_link.link_autoneg,
> suggesting ETH_LINK_SPEED_[AUTONEG/FIXED] which are 0/1,
> instead of ETH_LINK_[AUTONEG/FIXED] which are 1/0.
>
> The drivers are fixed to use ETH_LINK_[AUTONEG/FIXED].
>
> Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
>
> Suggested-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Thanks for clearing this up.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2018-01-05 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 17:38 [PATCH] ethdev: fix link autonegotiation value Thomas Monjalon
2018-01-05 20:47 ` Stephen Hemminger [this message]
2018-01-10 20:54 ` Ferruh Yigit
2018-01-08 12:31 ` Ferruh Yigit
2018-01-08 15:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105124707.602256c5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.