All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL 5/5] i.MX defconfig updates for 4.16
Date: Sat, 6 Jan 2018 10:55:12 +0800	[thread overview]
Message-ID: <20180106025510.GA20783@dragon> (raw)
In-Reply-To: <CAK8P3a2bWz5n+Scy_pvaHo0AJ5w0cuY1Fyiidc0Ygk0=7AF5-A@mail.gmail.com>

Hi Arnd,

On Fri, Jan 05, 2018 at 06:06:26PM +0100, Arnd Bergmann wrote:
> On Wed, Jan 3, 2018 at 6:57 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > The following changes since commit 50c4c4e268a2d7a3e58ebb698ac74da0de40ae36:
> >
> >   Linux 4.15-rc3 (2017-12-10 17:56:26 -0800)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/imx-defconfig-4.16
> >
> > for you to fetch changes up to 189114b47b1cfcc5da02db9bcafebd2042aa7ab8:
> >
> >   ARM: imx_v6_v7_defconfig: enable CONFIG_CPU_FREQ_STAT (2017-12-26 17:04:13 +0800)
> >
> > ----------------------------------------------------------------
> > i.MX defconfig updates for 4.16:
> >  - Enable CPU_FREQ_STAT for cpufreq transtion statistics support.
> >  - Enable SRTC driver RTC_DRV_MXC_V2 for i.MX53.
> >  - Turn on a few drivers useful for DART-MX6 SoM support, SERDEV
> >    bluetooth, SERIAL_DEV_BUS, WL18XX, and DEFAULT_ON LED Trigger.
> >
> > ----------------------------------------------------------------
> > Dong Aisheng (1):
> >       ARM: imx_v6_v7_defconfig: enable CONFIG_CPU_FREQ_STAT
> 
> This commit looks a bit fishy, as it does multiple things:
> 
> - add multitouch support

CONFIG_HID_MULTITOUCH is not a new option, but just got moved around.

> - move options around in the file that did not change
> - drop some options (AEABI, CMA, SOC_CAMERA_OV2640,
>    SERIAL_DEV_CTRL_TTYPORT) for unknown reasons.

All these changes came from savedefconfig.

> Cleaning up is fine, but please don't mix that with functional changes.
> It's also fine to add multiple options at once in one patch, but when
> you use 'make savedefconfig', please check each option that
> gets dropped, some options might have gained new dependencies
> or got renamed but are still needed here.

Agreed.  The savedefconfig change should really be a separate patch.

> Finally, it might be good to check if the newly added options should
> also be added to multi_v7_defconfig.
> 
> Not pulled for now, I'd suggest you resend without the 'savedefconfig'
> cleanup, we can do that in a follow-up.

Sorry for giving you a hard time on this.  I will rework it by adding
CONFIG_CPU_FREQ_STAT option only in that patch.

Shawn

  reply	other threads:[~2018-01-06  2:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03  5:57 [GIT PULL 1/5] i.MX drivers updates for 4.16 Shawn Guo
2018-01-03  5:57 ` [GIT PULL 2/5] i.MX SoC " Shawn Guo
2018-01-05 16:53   ` Arnd Bergmann
2018-01-03  5:57 ` [GIT PULL 3/5] i.MX device tree " Shawn Guo
2018-01-05 16:11   ` Arnd Bergmann
2018-01-03  5:57 ` [GIT PULL 4/5] Freescale arm64 " Shawn Guo
2018-01-05 16:12   ` Arnd Bergmann
2018-01-03  5:57 ` [GIT PULL 5/5] i.MX defconfig " Shawn Guo
2018-01-05 17:06   ` Arnd Bergmann
2018-01-06  2:55     ` Shawn Guo [this message]
2018-01-06  3:32   ` [GIT PULL v2 " Shawn Guo
2018-01-12  0:48     ` Olof Johansson
2018-01-05 16:56 ` [GIT PULL 1/5] i.MX drivers " Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180106025510.GA20783@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.