From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v6 07/14] regmap: Add SoundWire bus support Date: Sat, 6 Jan 2018 11:41:17 +0530 Message-ID: <20180106061116.GO18649@localhost> References: <1513230585-13882-1-git-send-email-vinod.koul@intel.com> <1513230585-13882-8-git-send-email-vinod.koul@intel.com> <20180105170421.GE9076@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by alsa0.perex.cz (Postfix) with ESMTP id AE6AF266E07 for ; Sat, 6 Jan 2018 07:07:11 +0100 (CET) Content-Disposition: inline In-Reply-To: <20180105170421.GE9076@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: ALSA , Charles Keepax , Sudheer Papothi , Takashi , Greg Kroah-Hartman , plai@codeaurora.org, LKML , Pierre , patches.audio@intel.com, srinivas.kandagatla@linaro.org, Sagar Dharia , alan@linux.intel.com List-Id: alsa-devel@alsa-project.org On Fri, Jan 05, 2018 at 05:04:21PM +0000, Mark Brown wrote: > On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: > > > + /* SoundWire register address are contiguous */ > > + if (config->reg_stride != 0) > > + return -ENOTSUPP; > > That doesn't mean the chip hasn't decided not to use half the addresses > for some reason - this isn't something the bus should be enforcing. Agreed, will drop this -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbeAFGHM (ORCPT + 1 other); Sat, 6 Jan 2018 01:07:12 -0500 Received: from mga03.intel.com ([134.134.136.65]:15294 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbeAFGHK (ORCPT ); Sat, 6 Jan 2018 01:07:10 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,320,1511856000"; d="scan'208";a="192825983" Date: Sat, 6 Jan 2018 11:41:17 +0530 From: Vinod Koul To: Mark Brown Cc: Takashi , Greg Kroah-Hartman , LKML , ALSA , Pierre , patches.audio@intel.com, alan@linux.intel.com, Charles Keepax , Sagar Dharia , srinivas.kandagatla@linaro.org, plai@codeaurora.org, Sudheer Papothi Subject: Re: [PATCH v6 07/14] regmap: Add SoundWire bus support Message-ID: <20180106061116.GO18649@localhost> References: <1513230585-13882-1-git-send-email-vinod.koul@intel.com> <1513230585-13882-8-git-send-email-vinod.koul@intel.com> <20180105170421.GE9076@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180105170421.GE9076@sirena.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 05, 2018 at 05:04:21PM +0000, Mark Brown wrote: > On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: > > > + /* SoundWire register address are contiguous */ > > + if (config->reg_stride != 0) > > + return -ENOTSUPP; > > That doesn't mean the chip hasn't decided not to use half the addresses > for some reason - this isn't something the bus should be enforcing. Agreed, will drop this -- ~Vinod