All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [RFC PATCH] pwm: add pwm-atmel from Linux kernel 4.14
Date: Sat, 6 Jan 2018 08:29:03 +0100	[thread overview]
Message-ID: <20180106072903.GA9286@ravnborg.org> (raw)
In-Reply-To: <20180105111930.m6l7oklzjevsw7ly@pengutronix.de>

Hi Sascha.

> > While working with this I get the impression that the core
> > should know about pwm channels and device_d pointer
> > should be part of the core data.
> 
> I know it's done like this in Linux. Any good reason to do this in
> barebox aswell besides of "do it as in Linux"?

The overall structure is something like this:

  PWM Controller       PWM Channel
  +------------+
  |            |     +------------+
  |  pwm_chip  |====>| pwm_device |+
  |            |     +------------+|
  +------------+      +------------+

And with the current core support each implementation
needs to provide their owm implementation of this.
And I can see the core has data I think belongs
on another level.

So having better core support should simplify the individual
implementations a bit - I think.

When I get pwm-atmel working I may try to give it a shot.
If things turns out positivie I will post patches.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-01-06  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01 21:33 [RFC PATCH] pwm: add pwm-atmel from Linux kernel 4.14 Sam Ravnborg
2018-01-05 11:19 ` Sascha Hauer
2018-01-06  7:29   ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180106072903.GA9286@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.