From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: [PATCH] drm/nouveau/disp/gf119: add missing drive vfunc ptr Date: Sat, 6 Jan 2018 10:59:41 -0500 Message-ID: <20180106155951.8416-1-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: David Airlie , nouveau@lists.freedesktop.org, Ben Skeggs , linux-kernel@vger.kernel.org List-Id: nouveau.vger.kernel.org Rml4ZXMgYnJva2VuIGRwIG9uIEdGMTE5OgoKICBDYWxsIFRyYWNlOgogICA/IG52a21fZHBfdHJh aW5fZHJpdmUrMHgxODMvMHgyYzAgW25vdXZlYXVdCiAgIG52a21fZHBfYWNxdWlyZSsweDRmMy8w eGNkMCBbbm91dmVhdV0KICAgbnY1MF9kaXNwX3N1cGVyXzJfMisweDVkLzB4NDcwIFtub3V2ZWF1 XQogICA/IG52a21fZGV2aW5pdF9wbGxfc2V0KzB4Zi8weDIwIFtub3V2ZWF1XQogICBnZjExOV9k aXNwX3N1cGVyKzB4MTljLzB4MmYwIFtub3V2ZWF1XQogICBwcm9jZXNzX29uZV93b3JrKzB4MTkz LzB4M2MwCiAgIHdvcmtlcl90aHJlYWQrMHgzNS8weDNiMAogICBrdGhyZWFkKzB4MTI1LzB4MTQw CiAgID8gcHJvY2Vzc19vbmVfd29yaysweDNjMC8weDNjMAogICA/IGt0aHJlYWRfcGFyaysweDYw LzB4NjAKICAgcmV0X2Zyb21fZm9yaysweDI1LzB4MzAKICBDb2RlOiAgQmFkIFJJUCB2YWx1ZS4K ICBSSVA6ICAgICAgICAgICAobnVsbCkgUlNQOiBmZmZmYjFlMjQzZTRiYzM4CiAgQ1IyOiAwMDAw MDAwMDAwMDAwMDAwCgpGaXhlczogYWY4NTM4OWM2MTRhIGRybS9ub3V2ZWF1L2Rpc3A6IHNodWZm bGUgZnVuY3Rpb25zIGFyb3VuZApTaWduZWQtb2ZmLWJ5OiBSb2IgQ2xhcmsgPHJvYmRjbGFya0Bn bWFpbC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9lbmdpbmUvZGlzcC9z b3JnZjExOS5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmttL2VuZ2luZS9kaXNwL3NvcmdmMTE5LmMg Yi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmttL2VuZ2luZS9kaXNwL3NvcmdmMTE5LmMKaW5k ZXggYTI5NzhhMzdiNGYzLi43MDBmYzc1NGYyOGEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9ub3V2ZWF1L252a20vZW5naW5lL2Rpc3Avc29yZ2YxMTkuYworKysgYi9kcml2ZXJzL2dwdS9k cm0vbm91dmVhdS9udmttL2VuZ2luZS9kaXNwL3NvcmdmMTE5LmMKQEAgLTE3NCw2ICsxNzQsNyBA QCBnZjExOV9zb3IgPSB7CiAJCS5saW5rcyA9IGdmMTE5X3Nvcl9kcF9saW5rcywKIAkJLnBvd2Vy ID0gZzk0X3Nvcl9kcF9wb3dlciwKIAkJLnBhdHRlcm4gPSBnZjExOV9zb3JfZHBfcGF0dGVybiwK KwkJLmRyaXZlID0gZ2YxMTlfc29yX2RwX2RyaXZlLAogCQkudmNwaSA9IGdmMTE5X3Nvcl9kcF92 Y3BpLAogCQkuYXVkaW8gPSBnZjExOV9zb3JfZHBfYXVkaW8sCiAJCS5hdWRpb19zeW0gPSBnZjEx OV9zb3JfZHBfYXVkaW9fc3ltLAotLSAKMi4xNC4zCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbeAFP74 (ORCPT + 1 other); Sat, 6 Jan 2018 10:59:56 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:36409 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753355AbeAFP7z (ORCPT ); Sat, 6 Jan 2018 10:59:55 -0500 X-Google-Smtp-Source: ACJfBotpw4CZZIAeGAJ8Jk5Vj+Assm0CYn+YzzrYVhL2sBbSXH8u+qL+4xBXAtp676hbA1Eqvfm0MA== From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: Rob Clark , Ben Skeggs , David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/nouveau/disp/gf119: add missing drive vfunc ptr Date: Sat, 6 Jan 2018 10:59:41 -0500 Message-Id: <20180106155951.8416-1-robdclark@gmail.com> X-Mailer: git-send-email 2.14.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Fixes broken dp on GF119: Call Trace: ? nvkm_dp_train_drive+0x183/0x2c0 [nouveau] nvkm_dp_acquire+0x4f3/0xcd0 [nouveau] nv50_disp_super_2_2+0x5d/0x470 [nouveau] ? nvkm_devinit_pll_set+0xf/0x20 [nouveau] gf119_disp_super+0x19c/0x2f0 [nouveau] process_one_work+0x193/0x3c0 worker_thread+0x35/0x3b0 kthread+0x125/0x140 ? process_one_work+0x3c0/0x3c0 ? kthread_park+0x60/0x60 ret_from_fork+0x25/0x30 Code: Bad RIP value. RIP: (null) RSP: ffffb1e243e4bc38 CR2: 0000000000000000 Fixes: af85389c614a drm/nouveau/disp: shuffle functions around Signed-off-by: Rob Clark --- drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c index a2978a37b4f3..700fc754f28a 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c @@ -174,6 +174,7 @@ gf119_sor = { .links = gf119_sor_dp_links, .power = g94_sor_dp_power, .pattern = gf119_sor_dp_pattern, + .drive = gf119_sor_dp_drive, .vcpi = gf119_sor_dp_vcpi, .audio = gf119_sor_dp_audio, .audio_sym = gf119_sor_dp_audio_sym, -- 2.14.3