From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandru Chirvasitu Subject: Re: PROBLEM: i915 causes complete desktop freezes in 4.15-rc5 Date: Sat, 6 Jan 2018 13:44:29 -0500 Message-ID: <20180106184429.GA1469@chirva-void> References: <151517474548.6838.1821139419472614998@mail.alporthouse.com> <20180105193724.ghxzkcdm4cgiskmi@D-69-91-141-110.dhcp4.washington.edu> <151518186129.6838.5497512563650996948@mail.alporthouse.com> <20180105195842.zryxccc74k7fi6gq@D-69-91-141-110.dhcp4.washington.edu> <151518256891.6838.7870621097092357743@mail.alporthouse.com> <20180105220518.cmmof6rritm4bmjh@D-69-91-141-110.dhcp4.washington.edu> <151523540026.6838.8552050096058843898@mail.alporthouse.com> <20180106132443.yzn2pkfruu7basl7@D-69-91-141-110.dhcp4.washington.edu> <20180106163835.jknrwjt52nhbzzlt@D-69-91-141-110.dhcp4.washington.edu> <151526009137.23681.11777101661125249780@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com [IPv6:2607:f8b0:400d:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A4536E2B1 for ; Sat, 6 Jan 2018 18:44:33 +0000 (UTC) Received: by mail-qk0-x242.google.com with SMTP id d202so9763522qkc.9 for ; Sat, 06 Jan 2018 10:44:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <151526009137.23681.11777101661125249780@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, kernel list , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org VGhhbmtzIQoKSXQncyBhbHNvIGEgbXlzdGVyeSB0byBtZSB3aHkgSSBuZXZlciBoYWQgYW55IGNy YXNoZXMgb24gYW55IG9mIHRoZQpvdGhlciBzeXN0ZW1zIHJ1bm5pbmcgb24gdGhpcyBtYWNoaW5l IHJ1bm5pbmcgdGhlIHNhbWUgKHVucGF0Y2hlZCkKa2VybmVscy4KCkknbSBhc3N1bWluZyB0aGUg d2luZG93IG1hbmFnZXIgbWlnaHQgaGF2ZSBzb21ldGhpbmcgdG8gZG8gd2l0aCBpdDoKYWxsIG9m IHRoZSBvdGhlcnMgYXJlIG9uIGkzIGFuZCB0aGUgYnVnZ3kgb25lJ3Mgb3BlbmJveCwgc28gcGVy aGFwcwp0aWxpbmcgdnMuIHN0YWNraW5nIG1ha2VzIGEgZGlmZmVyZW5jZT8KClRoZSBvbmUgcGF0 dGVybiBJIG5vdGljZWQgdG8gdGhlIGNyYXNoZXMgd2FzIHRoYXQgdGhleSBvY2N1cnJlZCB1cG9u Cm9wZW5pbmcgYSBuZXcgd2luZG93LgoKT24gU2F0LCBKYW4gMDYsIDIwMTggYXQgMDU6MzQ6NTFQ TSArMDAwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IFF1b3RpbmcgQWxleGFuZHJ1IENoaXJ2YXNp dHUgKDIwMTgtMDEtMDYgMTY6Mzg6MzUpCj4gPiBPbiBTYXQsIEphbiAwNiwgMjAxOCBhdCAwODoy NDo0M0FNIC0wNTAwLCBBbGV4YW5kcnUgQ2hpcnZhc2l0dSB3cm90ZToKPiA+ID4gVGhhbmsgeW91 IQo+ID4gPiAKPiA+ID4gSSdsbCBhcHBseSB0aGF0IG1vcmUgZWxhYm9yYXRlIHBhdGNoIHlvdSBz ZW50IGluIHRoZSBsb25nZXIgbWVzc2FnZSB0bwo+ID4gPiBteSBjbG9uZSBvZiB0aGUgcmVwbyBh bmQgc2VlIGlmIGl0IHN0aWxsIGZyZWV6ZXMuCj4gPiA+Cj4gPiAKPiA+IEknbSBvbiBpdCBub3cg d2l0aCBubyBmcmVlemVzIHlldCwgZGVzcGl0ZSB0cnlpbmcgbXkgYmVzdCA6KS4KPiA+IAo+ID4g SSBoYXZlIGEgcXVlc3Rpb24gdGhvdWdoOgo+ID4gCj4gPiA+IE9uIFNhdCwgSmFuIDA2LCAyMDE4 IGF0IDEwOjQzOjIwQU0gKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+ID4gPiBRdW90aW5n IEFsZXhhbmRydSBDaGlydmFzaXR1ICgyMDE4LTAxLTA1IDIyOjA1OjE4KQo+ID4gPiA+ID4gSGVy ZSB3ZSBnby4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gSSBoYXZlCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IENPTkZJR19QQUdFX1BPSVNPTklORyBub3Qgc2V0Cj4gPiA+ID4gPiBDT05GSUdfU0xVQl9TVEFU Uz15Cj4gPiA+ID4gPiBDT05GSUdfU0xVQl9ERUJVRyBub3Qgc2V0Cj4gPiA+ID4gPiBDT05GSUdf S0FTQU49eQo+ID4gPiA+ID4gCj4gPiA+ID4gPiAuY29uZmlnIGF0dGFjaGVkIGFsb25nIGFzIHdl bGwgZm9yIHZlcmlmaWNhdGlvbiwgaW4gY2FzZSBJIG1pc3NlZAo+ID4gPiA+ID4gYW55dGhpbmcu Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IEFnYWluIGNyYXNoZWQgYnkgYW4gYXR0ZW1wdCB0byBvcGVu IGEgdGVybWluYWwgd2luZG93Lgo+ID4gPiA+IAo+ID4gPiA+IEdvdGNoYSwKPiA+ID4gPiAKPiA+ ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+ID4gPiBpbmRleCBiMjEzMjJiNTA0MTkuLjk2 Y2Y0NmExMGI0ZSAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4g PiA+IEBAIC00NzIsNyArNDcyLDcgQEAgc3RhdGljIHZvaWQgX19mZW5jZV9zZXRfcHJpb3JpdHko c3RydWN0IGRtYV9mZW5jZSAqZmVuY2UsIGludCBwcmlvKQo+ID4gPiA+ICAgICAgICAgc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycTsKPiA+ID4gPiAgICAgICAgIHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZTsKPiA+ID4gPiAgCj4gPiA+ID4gLSAgICAgICBpZiAoIWRtYV9mZW5j ZV9pc19pOTE1KGZlbmNlKSkKPiA+ID4gPiArICAgICAgIGlmIChkbWFfZmVuY2VfaXNfc2lnbmFs ZWQoZmVuY2UpIHx8ICFkbWFfZmVuY2VfaXNfaTkxNShmZW5jZSkpCj4gPiA+ID4gICAgICAgICAg ICAgICAgIHJldHVybjsKPiA+ID4gPiAgCj4gPiA+ID4gICAgICAgICBycSA9IHRvX3JlcXVlc3Qo ZmVuY2UpOwo+ID4gCj4gPiBJIHdlbnQgYmFjayB0byBMaW51cycgdHJlZSBhbmQgY29tcGFyZWQg dGhlIHJlc3BlY3RpdmUgaTkxNV9nZW0uYwo+ID4gZmlsZXMgaW4gdGhlIDQuMTQgYW5kIDQuMTUt cmM2IGNvbW1pdHMuIFRoZSBvZmZlbmRpbmcgcGllY2Ugb2YgY29kZQo+ID4gc2VlbXMgdG8gYmUg aW4gYm90aCwgc28gSSBhbSB3b25kZXJpbmcgd2h5IEkgd2FzIG5vdCBnZXR0aW5nIGZyZWV6ZXMg YmVmb3JlIDQuMTUtcmMuCj4gCj4gWWVhaCwgSSBkZWJhdGVkIGFkZGluZyBhIGZpeGVzIGZvciBj b21taXQgNmI1ZTkwZjU4YzU2Cj4gKCJkcm0vaTkxNS9zY2hlZHVsZXI6IEJvb3N0IHByaW9yaXRp ZXMgZm9yIGZsaXBzIikgdGhhdCBpbnRyb2R1Y2VkIHRoaXMKPiBjb2RlLCBidXQgZGVjaWRlZCBp dCdzIGp1c3QgYW4gb3B0aW1pc2F0aW9uIGF0IHRoaXMgcG9pbnQgYW5kIHRoYXQgd2UKPiBzaG91 bGQgb25seSByZWdhcmQgY29tbWl0IDFmMTgxMjI1ZjhlYyAoImRybS9pOTE1L2V4ZWNsaXN0czog S2VlcAo+IHJlcXVlc3QtPnByaW9yaXR5IGZvciBpdHMgbGlmZXRpbWUiKSBmb3IgaW50cm9kdWNp bmcgdGhlIGJyZWFrYWdlLiBQcmlvcgo+IHRvIGNvbW1pdCAxZjE4MTIyIHRoZSBndWFyZCBhdCB0 aGUgc3RhcnQgb2YgZXhlY2xpc3RzX3NjaGVkdWxlKHByaW8gPD0KPiBycS0+cHJpb3RyZWUucHJp b3JpdHkpIGlzIHN1ZmZpY2llbnQgdG8gYXZvaWQgbWFuaXB1bGF0aW5nIHJldGlyZWQKPiBmZW5j ZXMsIGFuZCBzbyB3ZSB3ZXJlIGF2b2lkaW5nIHRoaXMgYnVnLgo+IC1DaHJpcwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbeAFSoe (ORCPT + 1 other); Sat, 6 Jan 2018 13:44:34 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:36252 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbeAFSod (ORCPT ); Sat, 6 Jan 2018 13:44:33 -0500 X-Google-Smtp-Source: ACJfBovnqHzcV9uhue8kEh+sx2sQy57vRdnev3okfFYqqduedgQWTMCUajWonKygHSFXdU4tOyNeyA== Date: Sat, 6 Jan 2018 13:44:29 -0500 From: Alexandru Chirvasitu To: Chris Wilson Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, kernel list Subject: Re: PROBLEM: i915 causes complete desktop freezes in 4.15-rc5 Message-ID: <20180106184429.GA1469@chirva-void> References: <151517474548.6838.1821139419472614998@mail.alporthouse.com> <20180105193724.ghxzkcdm4cgiskmi@D-69-91-141-110.dhcp4.washington.edu> <151518186129.6838.5497512563650996948@mail.alporthouse.com> <20180105195842.zryxccc74k7fi6gq@D-69-91-141-110.dhcp4.washington.edu> <151518256891.6838.7870621097092357743@mail.alporthouse.com> <20180105220518.cmmof6rritm4bmjh@D-69-91-141-110.dhcp4.washington.edu> <151523540026.6838.8552050096058843898@mail.alporthouse.com> <20180106132443.yzn2pkfruu7basl7@D-69-91-141-110.dhcp4.washington.edu> <20180106163835.jknrwjt52nhbzzlt@D-69-91-141-110.dhcp4.washington.edu> <151526009137.23681.11777101661125249780@mail.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <151526009137.23681.11777101661125249780@mail.alporthouse.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Thanks! It's also a mystery to me why I never had any crashes on any of the other systems running on this machine running the same (unpatched) kernels. I'm assuming the window manager might have something to do with it: all of the others are on i3 and the buggy one's openbox, so perhaps tiling vs. stacking makes a difference? The one pattern I noticed to the crashes was that they occurred upon opening a new window. On Sat, Jan 06, 2018 at 05:34:51PM +0000, Chris Wilson wrote: > Quoting Alexandru Chirvasitu (2018-01-06 16:38:35) > > On Sat, Jan 06, 2018 at 08:24:43AM -0500, Alexandru Chirvasitu wrote: > > > Thank you! > > > > > > I'll apply that more elaborate patch you sent in the longer message to > > > my clone of the repo and see if it still freezes. > > > > > > > I'm on it now with no freezes yet, despite trying my best :). > > > > I have a question though: > > > > > On Sat, Jan 06, 2018 at 10:43:20AM +0000, Chris Wilson wrote: > > > > Quoting Alexandru Chirvasitu (2018-01-05 22:05:18) > > > > > Here we go. > > > > > > > > > > I have > > > > > > > > > > CONFIG_PAGE_POISONING not set > > > > > CONFIG_SLUB_STATS=y > > > > > CONFIG_SLUB_DEBUG not set > > > > > CONFIG_KASAN=y > > > > > > > > > > .config attached along as well for verification, in case I missed > > > > > anything. > > > > > > > > > > Again crashed by an attempt to open a terminal window. > > > > > > > > Gotcha, > > > > > > > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > > > > index b21322b50419..96cf46a10b4e 100644 > > > > --- a/drivers/gpu/drm/i915/i915_gem.c > > > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > > > @@ -472,7 +472,7 @@ static void __fence_set_priority(struct dma_fence *fence, int prio) > > > > struct drm_i915_gem_request *rq; > > > > struct intel_engine_cs *engine; > > > > > > > > - if (!dma_fence_is_i915(fence)) > > > > + if (dma_fence_is_signaled(fence) || !dma_fence_is_i915(fence)) > > > > return; > > > > > > > > rq = to_request(fence); > > > > I went back to Linus' tree and compared the respective i915_gem.c > > files in the 4.14 and 4.15-rc6 commits. The offending piece of code > > seems to be in both, so I am wondering why I was not getting freezes before 4.15-rc. > > Yeah, I debated adding a fixes for commit 6b5e90f58c56 > ("drm/i915/scheduler: Boost priorities for flips") that introduced this > code, but decided it's just an optimisation at this point and that we > should only regard commit 1f181225f8ec ("drm/i915/execlists: Keep > request->priority for its lifetime") for introducing the breakage. Prior > to commit 1f18122 the guard at the start of execlists_schedule(prio <= > rq->priotree.priority) is sufficient to avoid manipulating retired > fences, and so we were avoiding this bug. > -Chris