From: Stephen Hemminger <stephen@networkplumber.org>
To: Filip Moc <dev@moc6.cz>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ip fou: Pass family attribute as u8
Date: Sun, 7 Jan 2018 12:28:48 -0800 [thread overview]
Message-ID: <20180107122848.3f2121c1@xeon-e3> (raw)
In-Reply-To: <20180107142813.s6k6h2s6u75bdut5@moc6.cz>
On Sun, 7 Jan 2018 15:28:13 +0100
Filip Moc <dev@moc6.cz> wrote:
> This fixes fou on big-endian systems.
>
> Signed-off-by: Filip Moc <dev@moc6.cz>
> ---
> ip/ipfou.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ip/ipfou.c b/ip/ipfou.c
> index febc2c8c..1f392ade 100644
> --- a/ip/ipfou.c
> +++ b/ip/ipfou.c
> @@ -52,7 +52,7 @@ static int fou_parse_opt(int argc, char **argv, struct nlmsghdr *n,
> __u8 ipproto, type;
> bool gue_set = false;
> int ipproto_set = 0;
> - unsigned short family = AF_INET;
> + __u8 family = AF_INET;
>
> while (argc > 0) {
> if (!matches(*argv, "port")) {
> @@ -103,7 +103,7 @@ static int fou_parse_opt(int argc, char **argv, struct nlmsghdr *n,
>
> addattr16(n, 1024, FOU_ATTR_PORT, port);
> addattr8(n, 1024, FOU_ATTR_TYPE, type);
> - addattr16(n, 1024, FOU_ATTR_AF, family);
> + addattr8(n, 1024, FOU_ATTR_AF, family);
>
> if (ipproto_set)
> addattr8(n, 1024, FOU_ATTR_IPPROTO, ipproto);
How is this binary compatiable with older versions.
next prev parent reply other threads:[~2018-01-07 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 14:28 [PATCH iproute2] ip fou: Pass family attribute as u8 Filip Moc
2018-01-07 20:28 ` Stephen Hemminger [this message]
2018-01-07 21:25 ` Filip Moc
2018-01-09 16:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180107122848.3f2121c1@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@moc6.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.