All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libselinux: set PREFIX to generate proper .pc file
Date: Sun, 7 Jan 2018 15:16:18 +0100	[thread overview]
Message-ID: <20180107151618.62c734e2@windsurf> (raw)
In-Reply-To: <20180106145249.3090-1-marcus.folkesson@gmail.com>

Hello,

Thanks for continuing the work on this topic!

On Sat,  6 Jan 2018 15:52:49 +0100, Marcus Folkesson wrote:
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>  package/libselinux/libselinux.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libselinux/libselinux.mk b/package/libselinux/libselinux.mk
> index 8ac8000de5..bf33da7f75 100644
> --- a/package/libselinux/libselinux.mk
> +++ b/package/libselinux/libselinux.mk
> @@ -43,17 +43,19 @@ LIBSELINUX_MAKE_INSTALL_TARGETS += install-pywrap
>  # dependencies are broken and result in file truncation errors at link
>  # time if the Python bindings are built through the same make
>  # invocation as the rest of the library.
> +# DESTDIR is needed during the compile to compute library and header paths.
>  define LIBSELINUX_BUILD_PYTHON_BINDINGS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
>  		$(LIBSELINUX_MAKE_OPTS) DESTDIR=$(STAGING_DIR) swigify pywrap
>  endef
>  endif # python || python3
>  
> +# DESTDIR is needed during the compile to compute library and header paths.
>  define LIBSELINUX_BUILD_CMDS
>  	# DESTDIR is needed during the compile to compute library and
>  	# header paths.
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
> -		$(LIBSELINUX_MAKE_OPTS) DESTDIR=$(STAGING_DIR) all
> +		$(LIBSELINUX_MAKE_OPTS) DESTDIR=$(STAGING_DIR) PREFIX=/usr all
>  	$(LIBSELINUX_BUILD_PYTHON_BINDINGS)
>  endef

How can this work without passing PREFIX=/usr also at install time ?
(Same question for libsemanage and libsepol).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2018-01-07 14:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-06 14:52 [Buildroot] [PATCH] libselinux: set PREFIX to generate proper .pc file Marcus Folkesson
2018-01-07  4:34 ` Matthew Weber
2018-01-07 14:16 ` Thomas Petazzoni [this message]
2018-01-07 16:24   ` Marcus Folkesson
2018-01-07 16:34     ` Thomas Petazzoni
2018-01-07 16:51       ` Marcus Folkesson
2018-01-07 19:40         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180107151618.62c734e2@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.