From: Jonathan Cameron <jic23@kernel.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: add field identifier for @use_count kernel-doc
Date: Sun, 7 Jan 2018 16:15:45 +0000 [thread overview]
Message-ID: <20180107161545.67ffed6f@archlinux> (raw)
In-Reply-To: <1515275766-31302-3-git-send-email-me@tobin.cc>
On Sun, 7 Jan 2018 08:56:06 +1100
"Tobin C. Harding" <me@tobin.cc> wrote:
> Kernel-doc for @use_count does not currently have a field identifier.
> All the rest of the fields do. @use_count is used internally and should
> not be accessed directly by the driver so it should be marked as so.
>
> Add [INTERN] identifier to @use_count field.
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilder to play with it.
Thanks,
Jonathan
> ---
> include/linux/iio/trigger.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 390789d43369..b19b7204ef84 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -49,7 +49,7 @@ struct iio_trigger_ops {
> * @dev: [DRIVER] associated device (if relevant)
> * @list: [INTERN] used in maintenance of global trigger list
> * @alloc_list: [DRIVER] used for driver specific trigger list
> - * @use_count: use count for the trigger
> + * @use_count: [INTERN] use count for the trigger.
> * @subirq_chip: [INTERN] associate 'virtual' irq chip.
> * @subirq_base: [INTERN] base number for irqs provided by trigger.
> * @subirqs: [INTERN] information about the 'child' irqs.
prev parent reply other threads:[~2018-01-07 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 21:56 [PATCH v3 0/2] fix kernel-docs for struct iio_trigger Tobin C. Harding
2018-01-06 21:56 ` [PATCH v3 1/2] iio: add kernel-doc for field @owner Tobin C. Harding
2018-01-07 16:13 ` Jonathan Cameron
2018-01-06 21:56 ` [PATCH v3 2/2] iio: add field identifier for @use_count kernel-doc Tobin C. Harding
2018-01-07 16:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180107161545.67ffed6f@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.