Re: [PATCH v2 13/23] vixen: Use SCHEDOP_shutdown to shutdown the machine

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Anthony Liguori <aliguori@amzn.com>
Cc: "Wei Liu" <wei.liu2@citrix.com>,
	"KarimAllah Ahmed" <karahmed@amazon.de>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Jan H. Schönherr" <jschoenh@amazon.de>,
	"Matt Wilson" <msw@amazon.com>,
	xen-devel@lists.xenproject.org,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2 13/23] vixen: Use SCHEDOP_shutdown to shutdown the machine
Date: Sun, 7 Jan 2018 19:22:53 -0500	[thread overview]
Message-ID: <20180108002253.GA21689@char.us.oracle.com> (raw)
In-Reply-To: <1515356919-922-14-git-send-email-aliguori@amzn.com>

On Sun, Jan 07, 2018 at 12:28:29PM -0800, Anthony Liguori wrote:
> From: Jan H. Schönherr <jschoenh@amazon.de>
> 
> While the hwdom_shutdown() is able to reboot the system, it fails to
> properly power it off. With SCHEDOP_shutdown, we delegate the problem.
> 
> Signed-off-by: Jan H. Schönherr <jschoenh@amazon.de>
> ---
>  xen/common/domain.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index b4d679e..ede377c 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -42,6 +42,7 @@
>  #include <xen/trace.h>
>  #include <xen/tmem.h>
>  #include <asm/setup.h>
> +#include <asm/guest/vixen.h>
>  
>  /* Linux config option: propageted to domain0 */
>  /* xen_processor_pmbits: xen control Cx, Px, ... */
> @@ -693,6 +694,17 @@ void __domain_crash_synchronous(void)
>  }
>  
>  
> +static void vixen_shutdown(u8 reason)
> +{
> +    struct sched_shutdown sched_shutdown = { .reason = reason };
> +
> +    if (!opt_noreboot)

Forgot the spaces around it..
(Not that this matters that much).
> +        HYPERVISOR_sched_op(SCHEDOP_shutdown, &sched_shutdown);
> +
> +    /* Fallback, in case the hypercall fails */
> +    hwdom_shutdown(reason);
> +}
> + 
>  void domain_shutdown(struct domain *d, u8 reason)
>  {
>      struct vcpu *v;
> @@ -703,6 +715,8 @@ void domain_shutdown(struct domain *d, u8 reason)
>          d->shutdown_code = reason;
>      reason = d->shutdown_code;
>  
> +    if ( is_vixen() )
> +        vixen_shutdown(reason);
>      if ( is_hardware_domain(d) )
>          hwdom_shutdown(reason);
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel