From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/4] dmaengine: xilinx_dma: populate dma caps properly From: Vinod Koul Message-Id: <20180108103845.GE18649@localhost> Date: Mon, 8 Jan 2018 16:08:45 +0530 To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com, joabreu@synopsys.com, mike.looijmans@topic.nl, kedare06@gmail.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBKYW4gMDMsIDIwMTggYXQgMTI6MTI6MDhQTSArMDUzMCwgS2VkYXJlc3dhcmEgcmFv IEFwcGFuYSB3cm90ZToKPiBXaGVuIGNsaWVudCBkcml2ZXIgdXNlcyBkbWFfZ2V0X3NsYXZlX2Nh cHMoKSBhcGksCj4gaXQgY2hlY2tzIGZvciBjZXJ0YWluIGZpZWxkcyBvZiBkbWFfZGV2aWNlIHN0 cnVjdAo+IGN1cnJlbnRseSBkcml2ZXIgaXMgbm90IHNldHRpbmdzIHRoZSBkaXJlY3Rpb25zIGFu ZCBhZGRyX3dpZHRocwo+IGZpZWxkcyByZXN1bHRpbmcgZG1hX2dldF9zbGF2ZV9jYXBzKCkgcmV0 dXJuaW5nIGZhaWx1cmUuCj4gCj4gVGhpcyBwYXRjaCBmaXhlcyB0aGlzIGlzc3VlIGJ5IHBvcHVs YXRpbmcgcHJvcGVyIHZhbHVlcwo+IHRvIHRoZSBzdHJ1Y3QgZG1hX2RldmljZSBkaXJlY3Rpb25z IGFuZCBhZGRyX3dpZHRocyBmaWVsZHMuCj4gCj4gU2lnbmVkLW9mZi1ieTogS2VkYXJlc3dhcmEg cmFvIEFwcGFuYSA8YXBwYW5hZEB4aWxpbnguY29tPgo+IC0tLQo+IENoYW5nZXMgZm9yIHYyOgo+ IC0tPiBJbXByb3ZlZCBjb21taXQgbWVzc2FnZSB0aXRsZSBhbmQgZGVzY3JpcHRpb24gCj4gYXMg c3VnZ2VzdGVkIGJ5IFZpbm9kLgo+IAo+ICBkcml2ZXJzL2RtYS94aWxpbngveGlsaW54X2RtYS5j IHwgNCArKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9kbWEveGlsaW54L3hpbGlueF9kbWEuYyBiL2RyaXZlcnMvZG1hL3hpbGlu eC94aWxpbnhfZG1hLmMKPiBpbmRleCA4OGQzMTdkLi4yMWFjOTU0IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZG1hL3hpbGlueC94aWxpbnhfZG1hLmMKPiArKysgYi9kcml2ZXJzL2RtYS94aWxpbngv eGlsaW54X2RtYS5jCj4gQEAgLTIzOTgsNiArMjM5OCw3IEBAIHN0YXRpYyBpbnQgeGlsaW54X2Rt YV9jaGFuX3Byb2JlKHN0cnVjdCB4aWxpbnhfZG1hX2RldmljZSAqeGRldiwKPiAgCQljaGFuLT5k aXJlY3Rpb24gPSBETUFfTUVNX1RPX0RFVjsKPiAgCQljaGFuLT5pZCA9IGNoYW5faWQ7Cj4gIAkJ Y2hhbi0+dGRlc3QgPSBjaGFuX2lkOwo+ICsJCXhkZXYtPmNvbW1vbi5kaXJlY3Rpb25zID0gQklU KERNQV9NRU1fVE9fREVWKTsKPiAgCj4gIAkJY2hhbi0+Y3RybF9vZmZzZXQgPSBYSUxJTlhfRE1B X01NMlNfQ1RSTF9PRkZTRVQ7Cj4gIAkJaWYgKHhkZXYtPmRtYV9jb25maWctPmRtYXR5cGUgPT0g WERNQV9UWVBFX1ZETUEpIHsKPiBAQCAtMjQxNSw2ICsyNDE2LDcgQEAgc3RhdGljIGludCB4aWxp bnhfZG1hX2NoYW5fcHJvYmUoc3RydWN0IHhpbGlueF9kbWFfZGV2aWNlICp4ZGV2LAo+ICAJCWNo YW4tPmRpcmVjdGlvbiA9IERNQV9ERVZfVE9fTUVNOwo+ICAJCWNoYW4tPmlkID0gY2hhbl9pZDsK PiAgCQljaGFuLT50ZGVzdCA9IGNoYW5faWQgLSB4ZGV2LT5ucl9jaGFubmVsczsKPiArCQl4ZGV2 LT5jb21tb24uZGlyZWN0aW9ucyB8PSBCSVQoRE1BX0RFVl9UT19NRU0pOwo+ICAKPiAgCQljaGFu LT5jdHJsX29mZnNldCA9IFhJTElOWF9ETUFfUzJNTV9DVFJMX09GRlNFVDsKPiAgCQlpZiAoeGRl di0+ZG1hX2NvbmZpZy0+ZG1hdHlwZSA9PSBYRE1BX1RZUEVfVkRNQSkgewo+IEBAIC0yNjI5LDYg KzI2MzEsOCBAQCBzdGF0aWMgaW50IHhpbGlueF9kbWFfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikKPiAgCQlkbWFfY2FwX3NldChETUFfUFJJVkFURSwgeGRldi0+Y29tbW9uLmNh cF9tYXNrKTsKPiAgCX0KPiAgCj4gKwl4ZGV2LT5jb21tb24uZHN0X2FkZHJfd2lkdGhzID0gQklU KGFkZHJfd2lkdGggLyA4KTsKPiArCXhkZXYtPmNvbW1vbi5zcmNfYWRkcl93aWR0aHMgPSBCSVQo YWRkcl93aWR0aCAvIDgpOwoKRG8geW91IG5vdCBzdXBwb3J0IHRyZiBvZiAxYnl0ZSwgMiBieXRl cywgb3IgNCBieXRlcyB3aWRlIHRyYW5zZmVycz8gV2hhdCBpcwp2YWx1ZSBvZiBhZGRyX3dpZHRo IGhlcmUgdHlwaWNhbGx5PyBVc3VhbGx5IGNvbnRyb2xsZXJzIGNhbiBzdXBwb3J0CmRpZmZlcmVu dCB3aWR0aHMgYW5kIHRoaXMgaXMgYSBzdXJwcmlzZSB0aGF0IHlvdSBzdXBwb3J0IG9ubHkgb25l IHZhbHVlCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Mon, 8 Jan 2018 16:08:45 +0530 Subject: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly In-Reply-To: <1514961731-1916-2-git-send-email-appanad@xilinx.com> References: <1514961731-1916-1-git-send-email-appanad@xilinx.com> <1514961731-1916-2-git-send-email-appanad@xilinx.com> Message-ID: <20180108103845.GE18649@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jan 03, 2018 at 12:12:08PM +0530, Kedareswara rao Appana wrote: > When client driver uses dma_get_slave_caps() api, > it checks for certain fields of dma_device struct > currently driver is not settings the directions and addr_widths > fields resulting dma_get_slave_caps() returning failure. > > This patch fixes this issue by populating proper values > to the struct dma_device directions and addr_widths fields. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > --> Improved commit message title and description > as suggested by Vinod. > > drivers/dma/xilinx/xilinx_dma.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c > index 88d317d..21ac954 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -2398,6 +2398,7 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev, > chan->direction = DMA_MEM_TO_DEV; > chan->id = chan_id; > chan->tdest = chan_id; > + xdev->common.directions = BIT(DMA_MEM_TO_DEV); > > chan->ctrl_offset = XILINX_DMA_MM2S_CTRL_OFFSET; > if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) { > @@ -2415,6 +2416,7 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev, > chan->direction = DMA_DEV_TO_MEM; > chan->id = chan_id; > chan->tdest = chan_id - xdev->nr_channels; > + xdev->common.directions |= BIT(DMA_DEV_TO_MEM); > > chan->ctrl_offset = XILINX_DMA_S2MM_CTRL_OFFSET; > if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) { > @@ -2629,6 +2631,8 @@ static int xilinx_dma_probe(struct platform_device *pdev) > dma_cap_set(DMA_PRIVATE, xdev->common.cap_mask); > } > > + xdev->common.dst_addr_widths = BIT(addr_width / 8); > + xdev->common.src_addr_widths = BIT(addr_width / 8); Do you not support trf of 1byte, 2 bytes, or 4 bytes wide transfers? What is value of addr_width here typically? Usually controllers can support different widths and this is a surprise that you support only one value -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756505AbeAHKeh (ORCPT + 1 other); Mon, 8 Jan 2018 05:34:37 -0500 Received: from mga14.intel.com ([192.55.52.115]:23729 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756478AbeAHKef (ORCPT ); Mon, 8 Jan 2018 05:34:35 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="193077009" Date: Mon, 8 Jan 2018 16:08:45 +0530 From: Vinod Koul To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com, joabreu@synopsys.com, mike.looijmans@topic.nl, kedare06@gmail.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly Message-ID: <20180108103845.GE18649@localhost> References: <1514961731-1916-1-git-send-email-appanad@xilinx.com> <1514961731-1916-2-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514961731-1916-2-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 03, 2018 at 12:12:08PM +0530, Kedareswara rao Appana wrote: > When client driver uses dma_get_slave_caps() api, > it checks for certain fields of dma_device struct > currently driver is not settings the directions and addr_widths > fields resulting dma_get_slave_caps() returning failure. > > This patch fixes this issue by populating proper values > to the struct dma_device directions and addr_widths fields. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > --> Improved commit message title and description > as suggested by Vinod. > > drivers/dma/xilinx/xilinx_dma.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c > index 88d317d..21ac954 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -2398,6 +2398,7 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev, > chan->direction = DMA_MEM_TO_DEV; > chan->id = chan_id; > chan->tdest = chan_id; > + xdev->common.directions = BIT(DMA_MEM_TO_DEV); > > chan->ctrl_offset = XILINX_DMA_MM2S_CTRL_OFFSET; > if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) { > @@ -2415,6 +2416,7 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev, > chan->direction = DMA_DEV_TO_MEM; > chan->id = chan_id; > chan->tdest = chan_id - xdev->nr_channels; > + xdev->common.directions |= BIT(DMA_DEV_TO_MEM); > > chan->ctrl_offset = XILINX_DMA_S2MM_CTRL_OFFSET; > if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) { > @@ -2629,6 +2631,8 @@ static int xilinx_dma_probe(struct platform_device *pdev) > dma_cap_set(DMA_PRIVATE, xdev->common.cap_mask); > } > > + xdev->common.dst_addr_widths = BIT(addr_width / 8); > + xdev->common.src_addr_widths = BIT(addr_width / 8); Do you not support trf of 1byte, 2 bytes, or 4 bytes wide transfers? What is value of addr_width here typically? Usually controllers can support different widths and this is a surprise that you support only one value -- ~Vinod