From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 01/13] net/bnxt: check return values in
 bnxt_dev_init
Date: Mon, 8 Jan 2018 12:53:35 -0800
Message-ID: <20180108125335.6d0900a5@xeon-e3>
References: <20180108202437.56305-1-ajit.khaparde@broadcom.com>
 <20180108202437.56305-2-ajit.khaparde@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46])
 by dpdk.org (Postfix) with ESMTP id 72B991B1C7
 for <dev@dpdk.org>; Mon,  8 Jan 2018 21:53:41 +0100 (CET)
Received: by mail-pg0-f46.google.com with SMTP id r2so6360644pgq.13
 for <dev@dpdk.org>; Mon, 08 Jan 2018 12:53:41 -0800 (PST)
In-Reply-To: <20180108202437.56305-2-ajit.khaparde@broadcom.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon,  8 Jan 2018 12:24:25 -0800
Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:

> +	rc = bnxt_hwrm_queue_qportcfg(bp);
> +	if (rc) {
> +		RTE_LOG(ERR, PMD, "hwrm queue qportcfg failed\n");
> +		goto error_free;
> +	}

I noticed that this driver is still using RTE_LOG directly.
The current desired behaviour is for each driver to define its own dynamic
log type (see i40e for an example).