All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Sumit Pundir <pundirsumit11@gmail.com>
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
	greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: greybus: Fix multiple checks for null pointers
Date: Mon, 8 Jan 2018 15:45:56 +0100	[thread overview]
Message-ID: <20180108144556.GG11344@localhost> (raw)
In-Reply-To: <1515391093-12677-1-git-send-email-pundirsumit11@gmail.com>

On Mon, Jan 08, 2018 at 11:28:13AM +0530, Sumit Pundir wrote:
> Fixes the following coding style issue as noted by checkpatch.pl
> at multiple lines:
> 
> Comparison to NULL could be written "!token"
> 
> Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>

Since you're not really fixing anything here, besides silencing a
checkpatch suggestion when run with the --strict option (or on staging
code), I suggest you reword you commit summary (Subject) to, for
example:

	staging: greybus: camera: clean up NULL checks

or similar.

Note that I also added "camera" as a module prefix above.

Thanks,
Johan

  reply	other threads:[~2018-01-08 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08  5:58 [PATCH] Staging: greybus: Fix multiple checks for null pointers Sumit Pundir
2018-01-08 14:45 ` Johan Hovold [this message]
2018-01-08 16:28   ` Sumit Pundir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108144556.GG11344@localhost \
    --to=johan@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pundirsumit11@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.