All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Hikaru Nishida <hikarupsp@gmail.com>
Cc: qemu-devel@nongnu.org, Keith Busch <keith.busch@intel.com>,
	Max Reitz <mreitz@redhat.com>,
	"open list:nvme" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe
Date: Mon, 8 Jan 2018 16:28:44 +0100	[thread overview]
Message-ID: <20180108152844.GH8052@localhost.localdomain> (raw)
In-Reply-To: <1513573243-29022-1-git-send-email-hikarupsp@gmail.com>

Am 18.12.2017 um 06:00 hat Hikaru Nishida geschrieben:
> Pin-based interrupt of NVMe controller did not work properly
> because using an obsolated function pci_irq_pulse().
> To fix this, change to use pci_irq_assert() / pci_irq_deassert()
> instead of pci_irq_pulse().
> 
> Signed-off-by: Hikaru Nishida <hikarupsp@gmail.com>

Thanks, applied to the block branch.

I had to resolve conflicts with the tracing patches and chose to keep
the trace points from pci_irq_pulse() for pci_irq_assert(), but didn't
add them to pci_irq_deassert(). Please check if this makes sense to you.
Here is the commit after my conflict resolution:

http://repo.or.cz/qemu/kevin.git/commitdiff/44c55a9159f2048a26c07e50dbc21c934917b82c

Kevin

  parent reply	other threads:[~2018-01-08 15:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18  5:00 [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe Hikaru Nishida
2017-12-22  7:31 ` Hikaru Nishida
2018-01-04 18:06   ` Hikaru Nishida
2018-01-04 18:20 ` Keith Busch
2018-01-08 15:28 ` Kevin Wolf [this message]
2018-01-09  0:38   ` Hikaru Nishida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108152844.GH8052@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=hikarupsp@gmail.com \
    --cc=keith.busch@intel.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.