From: Greg KH <gregkh@linuxfoundation.org>
To: Sumit Pundir <pundirsumit11@gmail.com>
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6656: fix unnecessary parantheses
Date: Mon, 8 Jan 2018 16:44:24 +0100 [thread overview]
Message-ID: <20180108154424.GA12786@kroah.com> (raw)
In-Reply-To: <1513952632-26737-1-git-send-email-pundirsumit11@gmail.com>
On Fri, Dec 22, 2017 at 07:53:52PM +0530, Sumit Pundir wrote:
> This patch fixes a coding style issue as noted by
> checkpatch.pl related to unnecessary parentheses.
>
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Unnecessary parentheses around 'priv->basic_rates'.
>
> Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
> ---
> drivers/staging/vt6656/card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index 501f482..811602e 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -443,7 +443,7 @@ int vnt_ofdm_min_rate(struct vnt_private *priv)
> int ii;
>
> for (ii = RATE_54M; ii >= RATE_6M; ii--) {
> - if ((priv->basic_rates) & ((u16)BIT(ii)))
> + if (priv->basic_rates & ((u16)BIT(ii)))
You still have one too many () around the BIT stuff...
next prev parent reply other threads:[~2018-01-08 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 14:23 [PATCH] Staging: vt6656: fix unnecessary parantheses Sumit Pundir
2018-01-08 15:44 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-25 5:35 [PATCH] Staging: vt6656: Fix " Sumit Pundir
2018-01-08 15:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108154424.GA12786@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pundirsumit11@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.