Re: [Qemu-devel] [PATCH] isa/piix: move to mips

["Michael S. Tsirkin" <mst@redhat.com>]

On Fri, Jan 05, 2018 at 04:15:18PM -0300, Philippe Mathieu-Daudé wrote:
> Hi Michael,
> 
> On Thu, Jan 4, 2018 at 8:21 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > This device is only used on mips, move to the correct maintainer
> > section.
> >
> > Cc: Aurelien Jarno <aurelien@aurel32.net>
> > Cc: Yongbok Kim <yongbok.kim@mips.com>
> > Cc: Hervé Poussineau <hpoussin@reactos.org>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  MAINTAINERS | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 0255113..ab30f1f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -175,6 +175,7 @@ F: include/hw/intc/mips_gic.h
> >  F: include/hw/timer/mips_gictimer.h
> >  F: tests/tcg/mips/
> >  F: disas/mips.c
> > +F: hw/isa/piix4.c
> 
> NACK this isn't the correct section (MIPS architecture),
> 
> The section you want to update is the "Malta board" one.
> 
> Now the 82371 devices are broadly use with X86 machines, so I am a bit
> reluctant to this change.
> 
> Maybe I am misunderstanding the 'X86 machines PC' entry, but I see you
> are the unique maintainer of this entry which status is "Supported:
> Someone is actually paid to look after this".
> My guess is you are paid to work on _recent_ PC machines and you are
> probably receiving too many patches.

As I said, I don't test mips. As long as isa/piix is not event built
on x86, it doesn't make sense for me to merge patches.

> I suggest we split this section in "recent PC" vs "outdated PC".
> It might be hard to draw a line, but maybe i440FX vs Q35 is a good one.
> If you agree to unburden some files you don't find relevant to the
> "recent PC" entry,
> Hervé and I volunteer for the "outdated PC" one with a "Odd Fixes" status
> (has a maintainer but they don't have time to do much other than throw
> the odd patch in).

That's not a level of support i440fx needs though, it's used
in production on too many systems.

> I hope you won't take this suggestion badly, we just offer help :)
> 
> Regards,
> 
> Phil.

For things that are actually used with x86 guests,
I think we are good, Marcel recently joined with that.

I'd like to split out pc bits that are not used with x86 guests.

> >  Moxie
> >  M: Anthony Green <green@moxielogic.com>
> > @@ -849,7 +850,6 @@ F: hw/pci-host/q35.c
> >  F: hw/pci-host/pam.c
> >  F: include/hw/pci-host/q35.h
> >  F: include/hw/pci-host/pam.h
> > -F: hw/isa/piix4.c
> >  F: hw/isa/lpc_ich9.c
> >  F: hw/i2c/smbus_ich9.c
> >  F: hw/acpi/piix4.c
> > --
> > MST