From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case. From: Mikhail Zaytsev Message-Id: <20180109004507.0b7ac1a2@debian> Date: Tue, 9 Jan 2018 00:45:30 +0300 To: Johan Hovold Cc: Oliver Neukum , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gTW9uLCA4IEphbiAyMDE4IDE2OjI4OjU4ICswMTAwIEpvaGFuIEhvdm9sZCA8am9oYW5Aa2Vy bmVsLm9yZz4gd3JvdGU6Cgo+IE9uIE1vbiwgSmFuIDA4LCAyMDE4IGF0IDExOjMzOjMyQU0gKzAx MDAsIE9saXZlciBOZXVrdW0gd3JvdGU6Cj4gPiBBbSBTYW1zdGFnLCBkZW4gMDYuMDEuMjAxOCwg MjA6MTQgKzAzMDAgc2NocmllYiBNaWtoYWlsIFpheXRzZXY6ICAKPiA+ID4gVGhlIHBhdGNoIHJl bW92ZXMgdW51c2VkIFRJT0NTU0VSSUFMIGlvY3RsIGNhc2UgYW5kIGFkZHMgdGhlIGRlZmF1bHQg YmxvY2sKPiA+ID4gdG8gdGhlIHN3aXRjaC4gVGhpcyB3aWxsIG1ha2UgdGhlIGlvY3RsIHJldHVy biAtRU5PVFRZIHRvIHVzZXIgc3BhY2UgKGUuZy4KPiA+ID4gc2V0c2VyaWFsKSwgYmVjYXVzZSBU SU9DU1NFUklBTCByZWFsbHkgaXNuJ3Qgc3VwcG9ydGVkIGZvciB0aGVzZSBkZXZpY2VzCj4gPiA+ IGN1cnJlbnRseS4gIAo+ID4gCj4gPiBIaSwKPiA+IAo+ID4gdGhpcyB3aWxsIGJyZWFrIHNvZnR3 YXJlIHRoYXQgaXMgbm93IHJ1bm5pbmcgb24gdGhlc2UgZGV2aWNlcywKPiA+IHdvbid0IGl0PyBE byB5b3Uga25vdyB3aHkgdGhvc2UgZGV2aWNlcyBiYXNpY2FsbHkgaWdub3JlIHRoZQo+ID4gaW9j dGw/ICAKPiAKPiBZZWFoLCB0aGF0IHdhcyBteSBpbml0aWFsIHJlYWN0aW9ucyBhcyB3ZWxsLCBi dXQgdGhlbiBhZ2FpbiwgYW55IHNhbmUKPiB1c2VyIHNwYWNlIGNhbm5vdCByZWx5IG9uIHRoZXNl IGlvY3RsIGJlaW5nIGltcGxlbWVudGVkIGZvciBhbGwgdHR5Cj4gZGV2aWNlcy4KPiAKPiBJIGRp ZCBzb21lIGRpZ2dpbmcgbm93IGFuZCB0aGVzZSAoZHVtbXkpIGlvY3RsIGltcGxlbWVudGF0aW9u cyB3aGVyZQo+IGFkZGVkIGJ5IGNvbW1pdCAyZjQzMGI0YmJhZTcgKCJVU0I6IGFyazMxMTY6IEFk ZCBUSU9DR1NFUklBTCBhbmQKPiBUSU9DU1NFUklBTCBpb2N0bCBjYWxscy4iKSBiYWNrIGluIDIw MDYuICBUaGlzIGluIHR1cm4gYXBwZWFycyB0byBoYXZlCj4gYmVlbiB0cmlnZ2VyZWQgYnkgYSBj aGFuZ2UgaW4gYSB1c2VyIHNwYWNlIHRvb2wsIHd2ZGlhbCwgd2hpY2ggc3RhcnRlZAo+IGVycm9y aW5nIG91dCBpZiBlaXRoZXIgd2FzIG1pc3NpbmcuCj4gCj4gSSBmb3VuZCBhIGNvdXBsZSBvZiBi dWcgcmVwb3J0cyBhYm91dCB0aGF0IHRocm91Z2ggZ29vZ2xlLCBhbmQgbG9va2luZwo+IGF0IHRo ZSB3dnN0cmVhbXMgKGxpYnJhcnkpIGNvZGUgbm93LCBpdCBsb29rcyBsaWtlIHRoZSBpc3N1ZSBo YXMgaW5kZWVkCj4gYmVlbiByZXNvbHZlZCBieSBoYW5kbGluZyBlcnJvcnMgbW9yZSBncmFjZWZ1 bGx5IChlLmcuIGp1c3QgbG9nZ2luZwo+IHRoZW0pLgo+IAo+IFNvIEknbSB3aWxsaW5nIHRvIGdp dmUgdGhpcyBhIHRyeSwgYW5kIGlmIGFueW9uZSBjb21wbGFpbnMgbGF0ZXIgd2UgYWRkCj4gYmFj ayAob3IgaW1wbGVtZW50KSBUSU9DU1NFUklBTC4KPiAKClRoYW5rcyBKb2hhbi4gSSBsb29rZWQg dGhlIGNvbW1pdCAyZjQzMGI0YmJhZTcuIEF1dGhvciBqdXN0IGRpZCBhIGN1dCduJ3Bhc3RlCiBm cm9tIG90aGVyIFVTQiBzZXJpYWwgZHJpdmVycy4gSSB0aGluayB0aGF0IGl0IHdvdWxkIGJlIGJl dHRlciByZW1vdmUKdGhlIFRJT0NHU0VSSUFMIGltcGxlbWVudGF0aW9uIHRvby4KCk1pa2hhaWwK LS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNj cmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdl ci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5v cmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932750AbeAHVpp (ORCPT + 1 other); Mon, 8 Jan 2018 16:45:45 -0500 Received: from smtp50.i.mail.ru ([94.100.177.110]:49652 "EHLO smtp50.i.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbeAHVpo (ORCPT ); Mon, 8 Jan 2018 16:45:44 -0500 Date: Tue, 9 Jan 2018 00:45:30 +0300 From: Mikhail Zaytsev To: Johan Hovold Cc: Oliver Neukum , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case. Message-ID: <20180109004507.0b7ac1a2@debian> In-Reply-To: <20180108152858.GH11344@localhost> References: <20180106200809.41cdd723@debian> <20180106201402.03d2ac88@debian> <1515407612.29712.1.camel@suse.com> <20180108152858.GH11344@localhost> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: smtp50.i.mail.ru; auth=pass smtp.auth=flashed@mail.ru smtp.mailfrom=flashed@mail.ru X-7FA49CB5: 0D63561A33F958A54EEB60FEC234656F44A2CA877C2D78180646075F00B0E1E5725E5C173C3A84C3E219FEC04DD79C21B4F6D134972FDF61F3CCD8A865B74A75C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F2AF38021CC9F462D574AF45C6390F7469DAA53EE0834AAEE X-Mailru-Sender: 159DE679A9C6F657CB201B8725788872660F17B30572B38EF767F76C9C5057D86B4C15F81911EFCF35240BD9E37F4C362F445727719BCECB540ECE9B597817E15BECAF0817D12387B4A721A3011E896F X-Mras: OK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, 8 Jan 2018 16:28:58 +0100 Johan Hovold wrote: > On Mon, Jan 08, 2018 at 11:33:32AM +0100, Oliver Neukum wrote: > > Am Samstag, den 06.01.2018, 20:14 +0300 schrieb Mikhail Zaytsev: > > > The patch removes unused TIOCSSERIAL ioctl case and adds the default block > > > to the switch. This will make the ioctl return -ENOTTY to user space (e.g. > > > setserial), because TIOCSSERIAL really isn't supported for these devices > > > currently. > > > > Hi, > > > > this will break software that is now running on these devices, > > won't it? Do you know why those devices basically ignore the > > ioctl? > > Yeah, that was my initial reactions as well, but then again, any sane > user space cannot rely on these ioctl being implemented for all tty > devices. > > I did some digging now and these (dummy) ioctl implementations where > added by commit 2f430b4bbae7 ("USB: ark3116: Add TIOCGSERIAL and > TIOCSSERIAL ioctl calls.") back in 2006. This in turn appears to have > been triggered by a change in a user space tool, wvdial, which started > erroring out if either was missing. > > I found a couple of bug reports about that through google, and looking > at the wvstreams (library) code now, it looks like the issue has indeed > been resolved by handling errors more gracefully (e.g. just logging > them). > > So I'm willing to give this a try, and if anyone complains later we add > back (or implement) TIOCSSERIAL. > Thanks Johan. I looked the commit 2f430b4bbae7. Author just did a cut'n'paste from other USB serial drivers. I think that it would be better remove the TIOCGSERIAL implementation too. Mikhail