All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Shunqian Zheng <zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add cif test clocks for rk3399
Date: Mon, 8 Jan 2018 17:56:13 -0800	[thread overview]
Message-ID: <20180109015612.GA180695@google.com> (raw)
In-Reply-To: <d8aef67f-1de0-0216-7b22-4e7990855353-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

On Tue, Jan 09, 2018 at 09:45:05AM +0800, Shunqian Zheng wrote:
> On 2018年01月09日 03:17, Brian Norris wrote:
> >On Mon, Jan 08, 2018 at 01:48:51PM +0800, Shunqian Zheng wrote:
> >>+			test_clkout2: test-clkout2 {
> >>+				rockchip,pins =
> >>+					<0 8 RK_FUNC_3 &pcfg_pull_none>;
> >Your function indexing is a little confusing to me, but one or more of
> >your datasheet, TRM, or patch are incorrect here. The datasheet says
> >"Func 3" (which is 1-indexed, so really means RK_FUNC_2) should be
> >TEST_CLKOUT2, but your TRM agrees with the patch, saying
> >2'b11=test_clkout2. So I think your patch is correct, but the datasheet
> >needs updated?
> Yeah, please follow the TRM.

Can you make sure the datasheet gets updated?

Thanks,
Brian

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2018-01-09  1:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08  5:48 [PATCH] arm64: dts: rockchip: Add cif test clocks for rk3399 Shunqian Zheng
     [not found] ` <1515390531-13147-1-git-send-email-zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-08 19:17   ` Brian Norris
     [not found]     ` <20180108191733.GA59523-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2018-01-09  1:45       ` Shunqian Zheng
     [not found]         ` <d8aef67f-1de0-0216-7b22-4e7990855353-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-09  1:56           ` Brian Norris [this message]
     [not found]             ` <20180109015612.GA180695-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2018-01-09  3:17               ` Shunqian Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109015612.GA180695@google.com \
    --to=briannorris-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.