From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v6] vhost: support virtqueue interrupt/notification suppression Date: Tue, 9 Jan 2018 10:29:34 +0800 Message-ID: <20180109022934.GE29540@yliu-mob> References: <1514048153-82959-1-git-send-email-junjie.j.chen@intel.com> <1514310190-140916-1-git-send-email-junjie.j.chen@intel.com> <20180108140659.GA29540@yliu-mob> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Wang, Xiao W" , "maxime.coquelin@redhat.com" , "Bie, Tiwei" , "dev@dpdk.org" , "Yao, Lei A" To: "Chen, Junjie J" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 73B0A1B1A4 for ; Tue, 9 Jan 2018 03:29:39 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 09, 2018 at 02:12:02AM +0000, Chen, Junjie J wrote: > > > + if (vring_need_event(vhost_used_event(vq), new, old) > > > > It's a bit weird that you use one from the standard linux header file > > (vring_need_event), while you define you own one (vhost_used_event). > > Note that the system header file also has "vring_used_event()" defined. > The vring_used_event is defined and used for virtio in kernel, kernel defines a vhost_used_event in vhost.c for vhost, so I just use a separated macro for vhost end. > > I'd like to define both vhost_need_event and vhost_used_event in vhost.h to remove potential build issue in old linux distribution and also to keep consistent. Is that OK for you? Yes. --yliu