From: Tejun Heo <tj@kernel.org>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: jbacik@fb.com, jack@suse.cz, axboe@kernel.dk, clm@fb.com,
kernel-team@fb.com, linux-kernel@vger.kernel.org,
linux-btrfs@vger.kernel.org, peterz@infradead.org,
Bart.VanAssche@wdc.com
Subject: Re: [PATCH 5/7] blk-mq: remove REQ_ATOM_COMPLETE usages from blk-mq
Date: Mon, 8 Jan 2018 19:37:48 -0800 [thread overview]
Message-ID: <20180109033748.GA3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <9b367cee-ecd8-cd45-9bdb-e79c29d956dd@oracle.com>
Hello,
On Tue, Jan 09, 2018 at 11:08:04AM +0800, jianchao.wang wrote:
> > But what'd prevent the completion reinitializing the request and then
> > the actual completion path coming in and completing the request again?
>
> blk_mark_rq_complete() will gate and ensure there will be only one
> __blk_mq_complete_request() to be invoked.
Yeah, but then the complete flag will be cleared once completion is
done and the request is reinitialized.
Thanks.
--
tejun
next prev parent reply other threads:[~2018-01-09 3:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 12:07 [PATCHSET v3] blk-mq: reimplement timeout handling Tejun Heo
2017-12-16 12:07 ` [PATCH 1/7] blk-mq: protect completion path with RCU Tejun Heo
2017-12-29 10:04 ` Christoph Hellwig
2018-01-08 17:12 ` Tejun Heo
2017-12-16 12:07 ` [PATCH 2/7] blk-mq: replace timeout synchronization with a RCU and generation based scheme Tejun Heo
2017-12-16 12:07 ` [PATCH 3/7] blk-mq: use blk_mq_rq_state() instead of testing REQ_ATOM_COMPLETE Tejun Heo
2017-12-16 12:07 ` [PATCH 4/7] blk-mq: make blk_abort_request() trigger timeout path Tejun Heo
2017-12-29 10:07 ` Christoph Hellwig
2017-12-16 12:07 ` [PATCH 5/7] blk-mq: remove REQ_ATOM_COMPLETE usages from blk-mq Tejun Heo
2017-12-21 3:56 ` jianchao.wang
2017-12-21 13:50 ` Tejun Heo
2017-12-22 4:02 ` jianchao.wang
2018-01-08 17:27 ` Tejun Heo
2018-01-09 3:08 ` jianchao.wang
2018-01-09 3:37 ` Tejun Heo [this message]
2018-01-09 5:59 ` jianchao.wang
2017-12-16 12:07 ` [PATCH 6/7] blk-mq: remove REQ_ATOM_STARTED Tejun Heo
2017-12-16 12:07 ` [PATCH 7/7] blk-mq: rename blk_mq_hw_ctx->queue_rq_srcu to ->srcu Tejun Heo
2017-12-29 10:02 ` [PATCHSET v3] blk-mq: reimplement timeout handling Christoph Hellwig
2018-01-08 17:03 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109033748.GA3668920@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=jianchao.w.wang@oracle.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.