From: Stephen Hemminger <stephen@networkplumber.org>
To: Antonio Quartulli <a@unstable.cc>
Cc: netdev@vger.kernel.org, Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [iproute2 1/2] ss: fix crash when skipping disabled header field
Date: Tue, 9 Jan 2018 08:03:26 -0800 [thread overview]
Message-ID: <20180109080326.000f603e@xeon-e3> (raw)
In-Reply-To: <20180106183150.10530-1-a@unstable.cc>
On Sun, 7 Jan 2018 02:31:49 +0800
Antonio Quartulli <a@unstable.cc> wrote:
> When the first header field is disabled (i.e. when passing the -t
> option), field_flush() is invoked with the `buffer` global variable
> still zero'd.
> However, in field_flush() we try to access buffer.cur->len
> during variables initialization, thus leading to a SIGSEGV.
>
> It's interesting to note that this bug appears only when the code
> is compiled with -O0, because the compiler is smart
> enough to immediately jump to the return statement if optimizations
> are enabled and skip the faulty instruction.
>
> Cc: Stefano Brivio <sbrivio@redhat.com>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Both applied, thanks.
prev parent reply other threads:[~2018-01-09 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 18:31 [iproute2 1/2] ss: fix crash when skipping disabled header field Antonio Quartulli
2018-01-06 18:31 ` [iproute2 2/2] ss: fix NULL pointer access when parsing unix sockets with oldformat Antonio Quartulli
2018-01-06 19:28 ` Stefano Brivio
2018-01-06 19:51 ` Antonio Quartulli
2018-01-06 18:53 ` [iproute2 1/2] ss: fix crash when skipping disabled header field Stefano Brivio
2018-01-09 16:03 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109080326.000f603e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=a@unstable.cc \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.