From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v2 2/2] arm64: Implement branch predictor hardening for Falkor Date: Tue, 9 Jan 2018 10:04:27 +0000 Message-ID: <20180109100426.GE4297@arm.com> References: <1515447068-20977-1-git-send-email-shankerd@codeaurora.org> <1515447068-20977-2-git-send-email-shankerd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3882A49DC8 for ; Tue, 9 Jan 2018 04:59:45 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bbEPxG2y3Pap for ; Tue, 9 Jan 2018 04:59:43 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5080249DD4 for ; Tue, 9 Jan 2018 04:59:43 -0500 (EST) Content-Disposition: inline In-Reply-To: <1515447068-20977-2-git-send-email-shankerd@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Shanker Donthineni Cc: Thomas Speier , Sean Campbell , Marc Zyngier , Catalin Marinas , linux-kernel , linux-arm-kernel , Paolo Bonzini , kvmarm List-Id: kvmarm@lists.cs.columbia.edu On Mon, Jan 08, 2018 at 03:31:08PM -0600, Shanker Donthineni wrote: > Falkor is susceptible to branch predictor aliasing and can > theoretically be attacked by malicious code. This patch > implements a mitigation for these attacks, preventing any > malicious entries from affecting other victim contexts. > > Signed-off-by: Shanker Donthineni > --- > Changes since v1: > Corrected typo to fix the compilation errors if HARDEN_BRANCH_PREDICTOR=n > > This patch requires FALKOR MIDR which is available in upstream v4.15-rc7 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64?h=v4.15-rc7&id=c622cc013cece073722592cff1ac6643a33b1622 ans also > attached this v2 patch series. Please resend this as a fixup on top of for-next/core. It might make the most sense to queue that at -rc1, after the MIDR change has already landed in mainline. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 9 Jan 2018 10:04:27 +0000 Subject: [PATCH v2 2/2] arm64: Implement branch predictor hardening for Falkor In-Reply-To: <1515447068-20977-2-git-send-email-shankerd@codeaurora.org> References: <1515447068-20977-1-git-send-email-shankerd@codeaurora.org> <1515447068-20977-2-git-send-email-shankerd@codeaurora.org> Message-ID: <20180109100426.GE4297@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 08, 2018 at 03:31:08PM -0600, Shanker Donthineni wrote: > Falkor is susceptible to branch predictor aliasing and can > theoretically be attacked by malicious code. This patch > implements a mitigation for these attacks, preventing any > malicious entries from affecting other victim contexts. > > Signed-off-by: Shanker Donthineni > --- > Changes since v1: > Corrected typo to fix the compilation errors if HARDEN_BRANCH_PREDICTOR=n > > This patch requires FALKOR MIDR which is available in upstream v4.15-rc7 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64?h=v4.15-rc7&id=c622cc013cece073722592cff1ac6643a33b1622 ans also > attached this v2 patch series. Please resend this as a fixup on top of for-next/core. It might make the most sense to queue that at -rc1, after the MIDR change has already landed in mainline. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753634AbeAIKE2 (ORCPT + 1 other); Tue, 9 Jan 2018 05:04:28 -0500 Received: from foss.arm.com ([217.140.101.70]:51068 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753604AbeAIKEZ (ORCPT ); Tue, 9 Jan 2018 05:04:25 -0500 Date: Tue, 9 Jan 2018 10:04:27 +0000 From: Will Deacon To: Shanker Donthineni Cc: Marc Zyngier , Christoffer Dall , linux-kernel , linux-arm-kernel , kvmarm , Paolo Bonzini , Catalin Marinas , James Morse , Vikram Sethi , Sean Campbell , Thomas Speier Subject: Re: [PATCH v2 2/2] arm64: Implement branch predictor hardening for Falkor Message-ID: <20180109100426.GE4297@arm.com> References: <1515447068-20977-1-git-send-email-shankerd@codeaurora.org> <1515447068-20977-2-git-send-email-shankerd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515447068-20977-2-git-send-email-shankerd@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 08, 2018 at 03:31:08PM -0600, Shanker Donthineni wrote: > Falkor is susceptible to branch predictor aliasing and can > theoretically be attacked by malicious code. This patch > implements a mitigation for these attacks, preventing any > malicious entries from affecting other victim contexts. > > Signed-off-by: Shanker Donthineni > --- > Changes since v1: > Corrected typo to fix the compilation errors if HARDEN_BRANCH_PREDICTOR=n > > This patch requires FALKOR MIDR which is available in upstream v4.15-rc7 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64?h=v4.15-rc7&id=c622cc013cece073722592cff1ac6643a33b1622 ans also > attached this v2 patch series. Please resend this as a fixup on top of for-next/core. It might make the most sense to queue that at -rc1, after the MIDR change has already landed in mainline. Will