All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Rosin <peda@axentia.se>
Cc: Hans de Goede <hdegoede@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] mux: core: fix double get_device()
Date: Tue, 9 Jan 2018 11:28:33 +0100	[thread overview]
Message-ID: <20180109102833.GC15608@kroah.com> (raw)
In-Reply-To: <20180108181952.29194-1-peda@axentia.se>

On Mon, Jan 08, 2018 at 07:19:52PM +0100, Peter Rosin wrote:
> From: Hans de Goede <hdegoede@redhat.com>
> 
> class_find_device already does a get_device on the returned device.
> So the device returned by of_find_mux_chip_by_node is already referenced
> and we should not reference it again (and unref it on error).
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  drivers/mux/core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Hi Greg,
> 
> Perhaps this was ignored due to more important stuff?

Yeah, the past few weeks have been a "bit" busy :(

I'll work to queue this up this week, sorry for the delay...

thanks,

greg k-h

      reply	other threads:[~2018-01-09 10:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 18:19 [RESEND PATCH] mux: core: fix double get_device() Peter Rosin
2018-01-09 10:28 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109102833.GC15608@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.