From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V2,5/5] usb: serial: f81534: fix tx error on some baud rate From: Johan Hovold Message-Id: <20180109113216.GR11344@localhost> Date: Tue, 9 Jan 2018 12:32:16 +0100 To: "Ji-Ze Hong \(Peter Hong\)" Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong \(Peter Hong\)" List-ID: T24gVGh1LCBKYW4gMDQsIDIwMTggYXQgMTA6Mjk6MjFBTSArMDgwMCwgSmktWmUgSG9uZyAoUGV0 ZXIgSG9uZykgd3JvdGU6Cj4gVGhlIEY4MTUzMi81MzQgaGFkIDQgY2xvY2tzb3VyY2UgMS44NDYv MTguNDYvMTQuNzcvMjRNSHogYW5kIGJhdWQgcmF0ZXMKPiBjYW4gYmUgdXAgdG8gMS41TWJpdHMg d2l0aCAyNE1Iei4gQnV0IG9uIHNvbWUgYmF1ZCByYXRlICgzODR+NTAwa3BzKSwgdGhlCj4gVFgg c2lkZSB3aWxsIHNlbmQgdGhlIGRhdGEgZnJhbWUgdG9vIGNsb3NlIHRvIHRyZWF0IGZyYW1lIGVy cm9yIG9uIFJYCj4gc2lkZS4gVGhpcyBwYXRjaCB3aWxsIGZvcmNlIGFsbCBUWCBkYXRhIGZyYW1l IHdpdGggZGVsYXkgMWJpdCBnYXAuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmktWmUgSG9uZyAoUGV0 ZXIgSG9uZykgPGhwZXRlcitsaW51eF9rZXJuZWxAZ21haWwuY29tPgo+IC0tLQo+IFYyOgo+IAkx OiBGaXJzdCBpbnRyb2R1Y2VkIGluIHRoaXMgc2VyaWVzIHBhdGNoZXMuCj4gCj4gIGRyaXZlcnMv dXNiL3NlcmlhbC9mODE1MzQuYyB8IDYgKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2Vy dGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc2VyaWFsL2Y4MTUzNC5jIGIv ZHJpdmVycy91c2Ivc2VyaWFsL2Y4MTUzNC5jCj4gaW5kZXggYTQ2NjYxNzEyMzlhLi41MTM4MDVl ZWFlNmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2Ivc2VyaWFsL2Y4MTUzNC5jCj4gKysrIGIv ZHJpdmVycy91c2Ivc2VyaWFsL2Y4MTUzNC5jCj4gQEAgLTEzMCw2ICsxMzAsNyBAQAo+ICAjZGVm aW5lIEY4MTUzNF9DTEtfMThfNDZfTUhaCQkoRjgxNTM0X1VBUlRfRU4gfCBCSVQoMSkpCj4gICNk ZWZpbmUgRjgxNTM0X0NMS18yNF9NSFoJCShGODE1MzRfVUFSVF9FTiB8IEJJVCgyKSkKPiAgI2Rl ZmluZSBGODE1MzRfQ0xLXzE0Xzc3X01IWgkJKEY4MTUzNF9VQVJUX0VOIHwgQklUKDEpIHwgQklU KDIpKQo+ICsjZGVmaW5lIEY4MTUzNF9DTEtfVFhfREVMQVlfMUJJVAlCSVQoMykKPiAgCj4gICNk ZWZpbmUgRjgxNTM0X0NMS19SUzQ4NV9NT0RFCQlCSVQoNCkKPiAgI2RlZmluZSBGODE1MzRfQ0xL X1JTNDg1X0lOVkVSVAkJQklUKDUpCj4gQEAgLTE0MzgsNiArMTQzOSwxMSBAQCBzdGF0aWMgaW50 IGY4MTUzNF9wb3J0X3Byb2JlKHN0cnVjdCB1c2Jfc2VyaWFsX3BvcnQgKnBvcnQpCj4gIAkJYnJl YWs7Cj4gIAl9Cj4gIAo+ICsJLyoKPiArCSAqIFdlJ2xsIG1ha2UgdHggZnJhbWUgZXJyb3Igd2hl biBiYXVkIHJhdGUgZnJvbSAzODR+NTAwa3BzLiBTbyB3ZSdsbAo+ICsJICogZGVsYXkgYWxsIHR4 IGRhdGEgZnJhbWUgd2l0aCAxYml0Lgo+ICsJICovCj4gKwlwb3J0X3ByaXYtPnNoYWRvd19jbGsg fD0gRjgxNTM0X0NMS19UWF9ERUxBWV8xQklUOwoKWW91IGRvbid0IHdhbid0IHRvIGVuYWJsZSB0 aGlzIG9ubHkgZm9yIHRoZSBhZmZlY3RlZCByYXRlcz8KCj4gIAlyZXR1cm4gZjgxNTM0X3NldF9w b3J0X291dHB1dF9waW4ocG9ydCk7Cj4gIH0KCkpvaGFuCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9t IHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUg Ym9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9y ZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754218AbeAILcV (ORCPT + 1 other); Tue, 9 Jan 2018 06:32:21 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:44573 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751682AbeAILcT (ORCPT ); Tue, 9 Jan 2018 06:32:19 -0500 X-Google-Smtp-Source: ACJfBoudPhhZQolKUa/gNWSH6LaKoqnTICtpvMYU+0BI5vdO0KKkNLJSqH5Xk+cXRnLTKXjKjNnYgw== Date: Tue, 9 Jan 2018 12:32:16 +0100 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate Message-ID: <20180109113216.GR11344@localhost> References: <1515032961-29131-1-git-send-email-hpeter+linux_kernel@gmail.com> <1515032961-29131-5-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515032961-29131-5-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates > can be up to 1.5Mbits with 24MHz. But on some baud rate (384~500kps), the > TX side will send the data frame too close to treat frame error on RX > side. This patch will force all TX data frame with delay 1bit gap. > > Signed-off-by: Ji-Ze Hong (Peter Hong) > --- > V2: > 1: First introduced in this series patches. > > drivers/usb/serial/f81534.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/usb/serial/f81534.c b/drivers/usb/serial/f81534.c > index a4666171239a..513805eeae6a 100644 > --- a/drivers/usb/serial/f81534.c > +++ b/drivers/usb/serial/f81534.c > @@ -130,6 +130,7 @@ > #define F81534_CLK_18_46_MHZ (F81534_UART_EN | BIT(1)) > #define F81534_CLK_24_MHZ (F81534_UART_EN | BIT(2)) > #define F81534_CLK_14_77_MHZ (F81534_UART_EN | BIT(1) | BIT(2)) > +#define F81534_CLK_TX_DELAY_1BIT BIT(3) > > #define F81534_CLK_RS485_MODE BIT(4) > #define F81534_CLK_RS485_INVERT BIT(5) > @@ -1438,6 +1439,11 @@ static int f81534_port_probe(struct usb_serial_port *port) > break; > } > > + /* > + * We'll make tx frame error when baud rate from 384~500kps. So we'll > + * delay all tx data frame with 1bit. > + */ > + port_priv->shadow_clk |= F81534_CLK_TX_DELAY_1BIT; You don't wan't to enable this only for the affected rates? > return f81534_set_port_output_pin(port); > } Johan