From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/2] USB: serial: ark3116: Move TIOCGSERIAL ioctl case to function. From: Johan Hovold Message-Id: <20180109115748.GT11344@localhost> Date: Tue, 9 Jan 2018 12:57:48 +0100 To: Mikhail Zaytsev Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gU2F0LCBKYW4gMDYsIDIwMTggYXQgMDg6MTU6MjJQTSArMDMwMCwgTWlraGFpbCBaYXl0c2V2 IHdyb3RlOgo+IFRoZSBwYXRjaCBtb3ZlcyBUSU9DR1NFUklBTCBpb2N0bCBjYXNlIHRvIGdldF9z ZXJpYWxfaW5mbyBmdW5jdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNaWtoYWlsIFpheXRzZXYg PGZsYXNoZWRAbWFpbC5ydT4KCj4gIHN0YXRpYyBpbnQgYXJrMzExNl9pb2N0bChzdHJ1Y3QgdHR5 X3N0cnVjdCAqdHR5LAo+ICAJCQkgdW5zaWduZWQgaW50IGNtZCwgdW5zaWduZWQgbG9uZyBhcmcp Cj4gIHsKPiAgCXN0cnVjdCB1c2Jfc2VyaWFsX3BvcnQgKnBvcnQgPSB0dHktPmRyaXZlcl9kYXRh Owo+IC0Jc3RydWN0IHNlcmlhbF9zdHJ1Y3Qgc2Vyc3RydWN0Owo+IC0Jdm9pZCBfX3VzZXIgKnVz ZXJfYXJnID0gKHZvaWQgX191c2VyICopYXJnOwoKSSBwcmVmZXIga2VlcGluZyB0aGlzIHBvaW50 ZXIgaGVyZSB0byBhdm9pZCBhZGRpbmcgY2FzdHMgdG8gZXZlcnkgaGVscGVyCmZ1bmN0aW9uIGNh bGwsIHNvIEkgYWRkZWQgaXQgYmFjayBiZWZvcmUgYXBwbHlpbmcuCgo+ICAKPiAgCXN3aXRjaCAo Y21kKSB7Cj4gIAljYXNlIFRJT0NHU0VSSUFMOgoKPiArCQlyZXR1cm4gYXJrMzExNl9nZXRfc2Vy aWFsX2luZm8ocG9ydCwKPiArCQkJCQkoc3RydWN0IHNlcmlhbF9zdHJ1Y3QgX191c2VyICopYXJn KTsKClRoYW5rcywKSm9oYW4KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5k IHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2Fn ZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0 dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755304AbeAIL54 (ORCPT + 1 other); Tue, 9 Jan 2018 06:57:56 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:33146 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853AbeAIL5v (ORCPT ); Tue, 9 Jan 2018 06:57:51 -0500 X-Google-Smtp-Source: ACJfBoua0jv1qijVI/K+NyxpcbTFu6UOlRyRfZZSYYyNu0knYt4UvYJZ806/ixeSCcaozWVxm5IqyQ== Date: Tue, 9 Jan 2018 12:57:48 +0100 From: Johan Hovold To: Mikhail Zaytsev Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] USB: serial: ark3116: Move TIOCGSERIAL ioctl case to function. Message-ID: <20180109115748.GT11344@localhost> References: <20180106200809.41cdd723@debian> <20180106201522.7a542d44@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180106201522.7a542d44@debian> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sat, Jan 06, 2018 at 08:15:22PM +0300, Mikhail Zaytsev wrote: > The patch moves TIOCGSERIAL ioctl case to get_serial_info function. > > Signed-off-by: Mikhail Zaytsev > static int ark3116_ioctl(struct tty_struct *tty, > unsigned int cmd, unsigned long arg) > { > struct usb_serial_port *port = tty->driver_data; > - struct serial_struct serstruct; > - void __user *user_arg = (void __user *)arg; I prefer keeping this pointer here to avoid adding casts to every helper function call, so I added it back before applying. > > switch (cmd) { > case TIOCGSERIAL: > + return ark3116_get_serial_info(port, > + (struct serial_struct __user *)arg); Thanks, Johan