From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO Date: Tue, 9 Jan 2018 16:34:16 +0100 Message-ID: <20180109153416.GA7780@kroah.com> References: <2e64e7d278fa9e4e255221fb84717884a7bfb69c.1513706701.git.joe@perches.com> <20171221093410.ygvupz3azaccxgnb@valkosipuli.retiisi.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171221093410.ygvupz3azaccxgnb@valkosipuli.retiisi.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sakari Ailus Cc: Don Brace , alsa-devel@alsa-project.org, Rich Felker , linux-sh@vger.kernel.org, David Airlie , Sebastian Ott , Heiko Carstens , linux-nvme@lists.infradead.org, James Smart , Keith Busch , Robert Jarzmik , Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, Mauro Carvalho Chehab , "James E.J. Bottomley" , Sagi Grimberg , Yoshinori Sato , esc.storagedev@microsemi.com, Russell King , linux-acpi@vger.kernel.org, Zhang Rui , Len Brown , Dick Kennedy , Corey Minyard List-Id: alsa-devel@alsa-project.org T24gVGh1LCBEZWMgMjEsIDIwMTcgYXQgMTE6MzQ6MTBBTSArMDIwMCwgU2FrYXJpIEFpbHVzIHdy b3RlOgo+IEhpIEpvZSwKPiAKPiBPbiBUdWUsIERlYyAxOSwgMjAxNyBhdCAxMDoxNTowOEFNIC0w ODAwLCBKb2UgUGVyY2hlcyB3cm90ZToKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcv bWVkaWEvYXRvbWlzcC9wY2kvYXRvbWlzcDIvaG1tL2htbS5jIGIvZHJpdmVycy9zdGFnaW5nL21l ZGlhL2F0b21pc3AvcGNpL2F0b21pc3AyL2htbS9obW0uYwo+ID4gaW5kZXggYTFjODFjMTI3MThj Li40MzM4YjhhMTMwOWYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvYXRv bWlzcC9wY2kvYXRvbWlzcDIvaG1tL2htbS5jCj4gPiArKysgYi9kcml2ZXJzL3N0YWdpbmcvbWVk aWEvYXRvbWlzcC9wY2kvYXRvbWlzcDIvaG1tL2htbS5jCj4gPiBAQCAtMTU4LDEwICsxNTgsMTAg QEAgc3RhdGljIHNzaXplX3QgZHluYW1pY19wb29sX3Nob3coc3RydWN0IGRldmljZSAqZGV2LAo+ ID4gIAlyZXR1cm4gcmV0Owo+ID4gIH07Cj4gPiAgCj4gPiAtc3RhdGljIERFVklDRV9BVFRSKGFj dGl2ZV9ibywgMDQ0NCwgYWN0aXZlX2JvX3Nob3csIE5VTEwpOwo+ID4gLXN0YXRpYyBERVZJQ0Vf QVRUUihmcmVlX2JvLCAwNDQ0LCBmcmVlX2JvX3Nob3csIE5VTEwpOwo+ID4gLXN0YXRpYyBERVZJ Q0VfQVRUUihyZXNlcnZlZF9wb29sLCAwNDQ0LCByZXNlcnZlZF9wb29sX3Nob3csIE5VTEwpOwo+ ID4gLXN0YXRpYyBERVZJQ0VfQVRUUihkeW5hbWljX3Bvb2wsIDA0NDQsIGR5bmFtaWNfcG9vbF9z aG93LCBOVUxMKTsKPiA+ICtzdGF0aWMgREVWSUNFX0FUVFJfUk8oYWN0aXZlX2JvKTsKPiA+ICtz dGF0aWMgREVWSUNFX0FUVFJfUk8oZnJlZV9ibyk7Cj4gPiArc3RhdGljIERFVklDRV9BVFRSX1JP KHJlc2VydmVkX3Bvb2wpOwo+ID4gK3N0YXRpYyBERVZJQ0VfQVRUUl9STyhkeW5hbWljX3Bvb2wp Owo+ID4gIAo+ID4gIHN0YXRpYyBzdHJ1Y3QgYXR0cmlidXRlICpzeXNmc19hdHRyc19jdHJsW10g PSB7Cj4gPiAgCSZkZXZfYXR0cl9hY3RpdmVfYm8uYXR0ciwKPiAKPiBJIGhhdmUgdGhlIGV4YWN0 IHNhbWUgY2hhbmdlcyBxdWV1ZWQgdXAgaW4gbXkgdHJlZS4gQXMgdGhlcmUgc2VlbSB0byBiZSBu bwo+IGRlcGVuZGVuY2llcyB0byBvdGhlciBwYXRjaGVzIGluIHlvdXIgc2V0LCBob3cgYWJvdXQg ZHJvcHBpbmcgdGhpcyBjaHVuaz8KCkkndmUgbm93IGRyb3BwZWQgaXQsIHRoYW5rcy4KCmdyZWcg ay1oCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 9 Jan 2018 16:34:16 +0100 From: Greg Kroah-Hartman To: Sakari Ailus Cc: Joe Perches , Don Brace , linux-nvme@lists.infradead.org, Rich Felker , linux-sh@vger.kernel.org, David Airlie , esc.storagedev@microsemi.com, Joonas Lahtinen , Heiko Carstens , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Russell King , Keith Busch , Robert Jarzmik , Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, "James E.J. Bottomley" , Sagi Grimberg , Yoshinori Sato , Takashi Iwai , Sebastian Ott , James Smart , linux-acpi@vger.kernel.org, Zhang Rui , Len Brown , Dick Kennedy , Corey Minyard , linux-pm@vger.kernel.org, Peter Oberparleiter , intel-gfx@lists.freedesktop.org, Haojian Zhuang , Jens Axboe , Mark Brown , Harald Freudenberger , Jani Nikula , Rodrigo Vivi , Jaroslav Kysela , openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Alan Cox , Eduardo Valentin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , "Rafael J. Wysocki" , Liam Girdwood , linux-kernel@vger.kernel.org, Arnd Bergmann , Sakari Ailus , Martin Schwidefsky , linux-media@vger.kernel.org, Daniel Mack Subject: Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO Message-ID: <20180109153416.GA7780@kroah.com> References: <2e64e7d278fa9e4e255221fb84717884a7bfb69c.1513706701.git.joe@perches.com> <20171221093410.ygvupz3azaccxgnb@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171221093410.ygvupz3azaccxgnb@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.9.2 (2017-12-15) X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote: > Hi Joe, > > On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote: > > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > index a1c81c12718c..4338b8a1309f 100644 > > --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > @@ -158,10 +158,10 @@ static ssize_t dynamic_pool_show(struct device *dev, > > return ret; > > }; > > > > -static DEVICE_ATTR(active_bo, 0444, active_bo_show, NULL); > > -static DEVICE_ATTR(free_bo, 0444, free_bo_show, NULL); > > -static DEVICE_ATTR(reserved_pool, 0444, reserved_pool_show, NULL); > > -static DEVICE_ATTR(dynamic_pool, 0444, dynamic_pool_show, NULL); > > +static DEVICE_ATTR_RO(active_bo); > > +static DEVICE_ATTR_RO(free_bo); > > +static DEVICE_ATTR_RO(reserved_pool); > > +static DEVICE_ATTR_RO(dynamic_pool); > > > > static struct attribute *sysfs_attrs_ctrl[] = { > > &dev_attr_active_bo.attr, > > I have the exact same changes queued up in my tree. As there seem to be no > dependencies to other patches in your set, how about dropping this chunk? I've now dropped it, thanks. greg k-h