All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Luis de Bethencourt <luisbg@kernel.org>,
	devel@driverdev.osuosl.org, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
	Joe Perches <joe@perches.com>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon
Date: Tue, 9 Jan 2018 17:46:05 +0100	[thread overview]
Message-ID: <20180109164605.GA7802@kroah.com> (raw)
In-Reply-To: <74881576-42ba-47a8-75d4-868149bdf68e@redhat.com>

On Tue, Jan 09, 2018 at 05:11:52PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 09-01-18 17:02, Luis de Bethencourt wrote:
> > On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
> > > > Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> > > > ---
> > > 
> > > I can't take patches without any changelog text, sorry :(
> > > 
> > 
> > Hi Greg,
> > 
> > I have done some research around previous patches to this driver and
> > I am not entirely sure what you mean.
> > 
> > Sorry, but I need to ask before sending a v2.
> > 
> > Do you mind I'm missing a small summary in the commit message? Fix is
> > so small I thought just the commit subject would be enough.
> > 
> > It is something different let me know and I will correct it.
> 
> I'm not entirely sure, but I believe Greg may have a script for this,
> given the amount of mail he receives and commits without a changelog
> in general not being a good idea.

No script for this, yet :)

> What I usually do with trivial patches like this, is simply take the
> part after the last : in the subject, append a "." and voila you've
> a changelog txt. So in this case that would simply be:
> 
> Fix trailing semicolon.

Ick, no, come on, you can do it correctly...

greg k-h

      parent reply	other threads:[~2018-01-09 16:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 15:09 [PATCH] staging: rtl8723bs: Fix trailing semicolon Luis de Bethencourt
2018-01-09 15:20 ` Greg Kroah-Hartman
2018-01-09 16:02   ` Luis de Bethencourt
2018-01-09 16:11     ` Hans de Goede
2018-01-09 16:13       ` Luis de Bethencourt
2018-01-09 16:46       ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109164605.GA7802@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=hadess@hadess.net \
    --cc=hdegoede@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luisbg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.