Re: [Qemu-devel] [PATCH v1 for-2-12 00/15] s390x: flic rework, tcg flic support and tcg

[Cornelia Huck <cohuck@redhat.com>]

On Mon, 11 Dec 2017 14:47:25 +0100
David Hildenbrand <david@redhat.com> wrote:

> This patch series implements floating interrupt support for TCG and fixes
> STSI so we can remove warnings related to s390x SMP and MTTCG.
> 
> KVM code has to be touched in order to factor out the injection routines
> into the flic ("s390x/flic: factor out injection of floating interrupts").
> Basic testing didn't reveal any problems so far.
> 
> With this series I am now able to run fedora 26/27 and Ubuntu 17.10+ with
> 16 VCPUs (MTTCG) on a 8CPU host, doing a make -j16 in the guest. I got
> nasty stalls in the guest beforehand.
> 
> I already sent the patches
>  - "cpus: make pause_all_cpus() play with SMP on single threaded TCG"
>  - "cpu-exec: fix missed CPU kick during interrupt injection"
> separately, but as nobody commented so far (e.g. due to 2.11) I am including
> them here as they are required to make SMP work reliably.
> 
> Based on: https://github.com/cohuck/qemu.git s390x-next
> Available at: https://github.com/davidhildenbrand/qemu.git s390x-queue

Generally, this looks good to me. I have commented on the individual
patches.

Looking forward to a v2 :)