From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758252AbeAIW5o (ORCPT + 1 other); Tue, 9 Jan 2018 17:57:44 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:40019 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbeAIW5m (ORCPT ); Tue, 9 Jan 2018 17:57:42 -0500 X-Google-Smtp-Source: ACJfBovFJTmEH9uV70v0cIk8FV/Y3puAbpHG5RvIWnWkkQkIv3oncx+5fXXvLPMbRPJ7pLKLW8tR8g== Date: Tue, 9 Jan 2018 14:57:40 -0800 From: Guenter Roeck To: Jesper Dangaard Brouer Cc: netdev@vger.kernel.org, Daniel Borkmann , linux-kernel@vger.kernel.org, Alexei Starovoitov Subject: Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set Message-ID: <20180109225740.GC26819@roeck-us.net> References: <20180109233742.101bfa1a@redhat.com> <151553775426.22654.5680031281102493621.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <151553775426.22654.5680031281102493621.stgit@firesoul> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 09, 2018 at 11:42:34PM +0100, Jesper Dangaard Brouer wrote: > The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info") > removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to > remove the corresponding ifdef's in include/linux/netdevice.h. > > Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info") > Reported-by: Guenter Roeck > Signed-off-by: Jesper Dangaard Brouer Tested-by: Guenter Roeck > --- > include/linux/netdevice.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 440b000f07f4..b308793c64ce 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1805,12 +1805,9 @@ struct net_device { > /* Interface address info used in eth_type_trans() */ > unsigned char *dev_addr; > > -#ifdef CONFIG_SYSFS > struct netdev_rx_queue *_rx; > - > unsigned int num_rx_queues; > unsigned int real_num_rx_queues; > -#endif > > struct bpf_prog __rcu *xdp_prog; > unsigned long gro_flush_timeout; >