From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: use %pS printk format for direct instruction addresses
Date: Wed, 10 Jan 2018 10:01:01 +1100 [thread overview]
Message-ID: <20180109230101.GO16421@dastard> (raw)
In-Reply-To: <151553076542.16288.14073908543082638592.stgit@magnolia>
On Tue, Jan 09, 2018 at 12:46:05PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Use the %pS instead of the %pF printk format specifier for printing
> symbols from direct addresses. This is needed for the ia64, ppc64 and
> parisc64 architectures.
I think we've done this conversion at least once before :/
> While we're at it, be consistent with the capitalization of the 'S'.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/scrub/trace.h | 20 ++++++++++----------
> fs/xfs/xfs_inode.c | 4 ++--
> fs/xfs/xfs_trace.h | 22 +++++++++++-----------
> 3 files changed, 23 insertions(+), 23 deletions(-)
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-01-09 23:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 20:45 [PATCH 0/3] xfs: printk fixes Darrick J. Wong
2018-01-09 20:45 ` [PATCH 1/3] xfs: change 0x%p -> %p in print messages Darrick J. Wong
2018-01-09 22:59 ` Dave Chinner
2018-01-09 20:46 ` [PATCH 2/3] xfs: use %pS printk format for direct instruction addresses Darrick J. Wong
2018-01-09 23:01 ` Dave Chinner [this message]
2018-01-09 20:46 ` [PATCH 3/3] xfs: use %px for data pointers when debugging Darrick J. Wong
2018-01-09 23:04 ` Dave Chinner
2018-01-09 23:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109230101.GO16421@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.