From: Christoph Hellwig <hch@lst.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-pci@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] pci-dma-compat: remove handling of NULL pdev arguments
Date: Wed, 10 Jan 2018 09:14:26 +0100 [thread overview]
Message-ID: <20180110081426.GC9659@lst.de> (raw)
In-Reply-To: <20180110002544.GA157182@bhelgaas-glaptop.roam.corp.google.com>
On Tue, Jan 09, 2018 at 06:25:44PM -0600, Bjorn Helgaas wrote:
> It looks like "pci_free_consistent(NULL" is still used in
> drivers/net/ethernet/tundra/tsi108_eth.c.
Yikes. That one needs to pass the device is the platform dev to
the dma_map_* routines to start with, and mixing that with PCI
is pretty horrible. I'll add a conversion of that driver to the
next resend.
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> With Mauro's ack on the media/ttusb-dev patches, I could merge the
> whole series via the PCI tree?
Fine with me.
prev parent reply other threads:[~2018-01-10 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 20:39 remove pci_dma_* abuses and workarounds Christoph Hellwig
2018-01-09 20:39 ` [PATCH 1/3] media/ttusb-budget: remove pci_zalloc_coherent abuse Christoph Hellwig
2018-01-09 20:49 ` Joe Perches
2018-01-10 8:17 ` Christoph Hellwig
2018-01-09 23:45 ` Bjorn Helgaas
2018-01-09 20:39 ` [PATCH 2/3] media/ttusb-dev: " Christoph Hellwig
2018-01-09 20:39 ` [PATCH 3/3] pci-dma-compat: remove handling of NULL pdev arguments Christoph Hellwig
2018-01-10 0:25 ` Bjorn Helgaas
2018-01-10 8:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110081426.GC9659@lst.de \
--to=hch@lst.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.