From: Stephen Hemminger <stephen@networkplumber.org>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: Netdev <netdev@vger.kernel.org>, Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH iproute2 v2 0/2] tests: fix issues in autopkgtest environment
Date: Wed, 10 Jan 2018 08:31:14 -0800 [thread overview]
Message-ID: <20180110083114.0bc55ae5@xeon-e3> (raw)
In-Reply-To: <1515597097-870-1-git-send-email-christian.ehrhardt@canonical.com>
On Wed, 10 Jan 2018 16:11:35 +0100
Christian Ehrhardt <christian.ehrhardt@canonical.com> wrote:
> Hi,
> while working on Debian bug [1] and the Ubuntu counterpart of it
> I found that the tests can throw a broken pipe warning.
>
> I kept the associated check-and-retry of the length separate to
> discuss the changes individually - feel free to squash them on
> commit if preferred.
>
> *Updates in v2*
> tag with --subject-prefix='PATCH iproute2' to trigger the right
> review queues in patchwork as requested by Luca Bocassi.
>
> [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879854
>
> Christian Ehrhardt (2):
> tests: read limited amount from /dev/urandom
> tests: make sure rand_dev suffix has 6 chars
>
> testsuite/lib/generic.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Looks good. Applied.
The method of generating a name seems a bit overly complex.
Maybe using something like pwgen would be easier.
prev parent reply other threads:[~2018-01-10 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 15:11 [PATCH iproute2 v2 0/2] tests: fix issues in autopkgtest environment Christian Ehrhardt
2018-01-10 15:11 ` [PATCH iproute2 v2 1/2] tests: read limited amount from /dev/urandom Christian Ehrhardt
2018-01-10 15:11 ` [PATCH iproute2 v2 2/2] tests: make sure rand_dev suffix has 6 chars Christian Ehrhardt
2018-01-10 16:31 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110083114.0bc55ae5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.