From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V2,5/5] usb: serial: f81534: fix tx error on some baud rate From: Johan Hovold Message-Id: <20180110085037.GW11344@localhost> Date: Wed, 10 Jan 2018 09:50:37 +0100 To: "Ji-Ze Hong \(Peter Hong\)" Cc: Johan Hovold , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong \(Peter Hong\)" List-ID: T24gV2VkLCBKYW4gMTAsIDIwMTggYXQgMDE6NDI6MzJQTSArMDgwMCwgSmktWmUgSG9uZyAoUGV0 ZXIgSG9uZykgd3JvdGU6Cj4gSGkgSm9oYW4sCj4gCj4gSm9oYW4gSG92b2xkIOaWvCAyMDE4LzEv OSDkuIvljYggMDc6MzIg5a+r6YGTOgo+ID4gT24gVGh1LCBKYW4gMDQsIDIwMTggYXQgMTA6Mjk6 MjFBTSArMDgwMCwgSmktWmUgSG9uZyAoUGV0ZXIgSG9uZykgd3JvdGU6Cj4gPj4gKwkvKgo+ID4+ ICsJICogV2UnbGwgbWFrZSB0eCBmcmFtZSBlcnJvciB3aGVuIGJhdWQgcmF0ZSBmcm9tIDM4NH41 MDBrcHMuIFNvIHdlJ2xsCj4gPj4gKwkgKiBkZWxheSBhbGwgdHggZGF0YSBmcmFtZSB3aXRoIDFi aXQuCj4gPj4gKwkgKi8KPiA+PiArCXBvcnRfcHJpdi0+c2hhZG93X2NsayB8PSBGODE1MzRfQ0xL X1RYX0RFTEFZXzFCSVQ7Cj4gPiAKPiA+IFlvdSBkb24ndCB3YW4ndCB0byBlbmFibGUgdGhpcyBv bmx5IGZvciB0aGUgYWZmZWN0ZWQgcmF0ZXM/Cj4gPiAKPiAKPiBUaGlzIGJpdCB3aWxsIGNvbnRy b2wgYWxsIHRyYW5zbWl0IFRYIGZyYW1lIGFsd2F5cyBkZWxheSAxIGJpdAo+IG9uIGVuYWJsZWQs IGJ1dCBJdCdsbCB0cmFuc21pdCBUWCBmcmFtZSByYW5kb21seSBkZWxheSAxIGJpdCBvbgo+IGRp c2FibGVkLgo+IAo+IFdlIGhhZCB0ZXN0ZWQgaXQgd2l0aCBCdXJuSW5UZXN0IHRvIGNoZWNrIHRo ZSBwZXJmb3JtYW5jZSwKPiBJdCdsbCBub3QgbWFrZSB0aGUgcGVyZm9ybWFuY2UgcmVncmVzc2lv bi4gU28gd2UnbGwgZGlyZWN0bHkgYWRkCj4gaXQgb24gYWxsIGJhdWQgcmF0ZS4KCk9rLCB0aGFu a3MgZm9yIGNvbmZpcm1pbmcuCgpKb2hhbgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxp c3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2Yg YSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5m byBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbeAJIum (ORCPT + 1 other); Wed, 10 Jan 2018 03:50:42 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:43996 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752127AbeAJIuk (ORCPT ); Wed, 10 Jan 2018 03:50:40 -0500 X-Google-Smtp-Source: ACJfBotpPhi4i/8spXJT2iteqiqmd4Gks+bsLuL6s6r9rxoNohf89CbcaPYz/XoSttQhu810dXmQAQ== Date: Wed, 10 Jan 2018 09:50:37 +0100 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: Johan Hovold , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate Message-ID: <20180110085037.GW11344@localhost> References: <1515032961-29131-1-git-send-email-hpeter+linux_kernel@gmail.com> <1515032961-29131-5-git-send-email-hpeter+linux_kernel@gmail.com> <20180109113216.GR11344@localhost> <747ab8c9-50cc-2bbb-6f58-758e3361cbe2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <747ab8c9-50cc-2bbb-6f58-758e3361cbe2@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 01:42:32PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > Johan Hovold 於 2018/1/9 下午 07:32 寫道: > > On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote: > >> + /* > >> + * We'll make tx frame error when baud rate from 384~500kps. So we'll > >> + * delay all tx data frame with 1bit. > >> + */ > >> + port_priv->shadow_clk |= F81534_CLK_TX_DELAY_1BIT; > > > > You don't wan't to enable this only for the affected rates? > > > > This bit will control all transmit TX frame always delay 1 bit > on enabled, but It'll transmit TX frame randomly delay 1 bit on > disabled. > > We had tested it with BurnInTest to check the performance, > It'll not make the performance regression. So we'll directly add > it on all baud rate. Ok, thanks for confirming. Johan