From: "Daniel P. Berrange" <berrange@redhat.com>
To: byxk <patricktsen@gmail.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/1] input-linux: provide hotkeys for evdev toggle
Date: Wed, 10 Jan 2018 16:30:03 +0000 [thread overview]
Message-ID: <20180110163003.GO3205@redhat.com> (raw)
In-Reply-To: <20180107221455.25504-1-patricktsen@gmail.com>
On Sun, Jan 07, 2018 at 02:14:54PM -0800, byxk wrote:
> Added some functionality to change the key combo for evdev toggle.
> example:
> -object input-linux,rhotkey=29,lhotkey=56,evdev=[etc...]
>
> Set the defaults to LCTRL and RCTRL if not provided.
This should really be part of the commit message for the patch itself, so it
gets recorded in git history.
There is some overlap here with the grab sequence work John has just posted
for cocoa frontend
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg05115.html
I wonder if it is reasonable for ui/input-linux.c to honour the same
global '-ungrab' configuration option ? If not, we should at least
use the same syntax for describing the ungrab sequence. ie a list of
key code names, rather than a hardcoded pair of numeric values.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-01-10 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 22:14 [Qemu-devel] [PATCH v2 0/1] input-linux: provide hotkeys for evdev toggle byxk
2018-01-07 22:14 ` [Qemu-devel] [PATCH 1/1] " byxk
2018-01-10 16:30 ` Daniel P. Berrange [this message]
2018-01-10 17:06 ` [Qemu-devel] [PATCH v2 0/1] " Patrick Tseng
2018-01-11 9:38 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110163003.GO3205@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=patricktsen@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.