Re: [PATCH] librdmacm: Set errno correctly if status is positive

[Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>]

On Wed, Jan 10, 2018 at 06:07:21PM +0200, Yuval Shaia wrote:
> No need to convert to positive if status is already positive.
> 
> Fixes: 1ef5c3a84 ("librdmacm: Set errno correctly in ucma_complete")
> 
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>  librdmacm/cma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/librdmacm/cma.c b/librdmacm/cma.c
> index 25ebaaee..fb2dc5e4 100644
> +++ b/librdmacm/cma.c
> @@ -866,7 +866,7 @@ int ucma_complete(struct rdma_cm_id *id)
>  		else if (id_priv->id.event->status < 0)
>  			ret = ERR(-id_priv->id.event->status);
>  		else
> -			ret = ERR(-id_priv->id.event->status);
> +			ret = ERR(id_priv->id.event->status);

This code hurts my brain - why is status sometimes a possitive errno
and sometimes a negative errno?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html