From: Stephen Boyd <sboyd@codeaurora.org>
To: sean.wang@mediatek.com
Cc: mturquette@baylibre.com, matthias.bgg@gmail.com,
jdelvare@suse.de, jamesjj.liao@mediatek.com,
weiyi.lu@mediatek.com, kevin-cw.chen@mediatek.com,
shunli.wang@mediatek.com, chen.zhong@mediatek.com, arnd@arndb.de,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clk: mediatek: adjust dependency of reset.c to avoid unexpectedly being built
Date: Wed, 10 Jan 2018 13:45:21 -0800 [thread overview]
Message-ID: <20180110214521.GE28313@codeaurora.org> (raw)
In-Reply-To: <0a88c7902606e819438ef0f1fc5968960e718620.1515139760.git.sean.wang@mediatek.com>
On 01/05, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Changes from v1->v2:
> Add 'select RESET_CONTROLLER' under COMMON_CLK_MEDIATEK and enable
> reset.c to be built when COMMON_CLK_MEDIATEK is selected. That should
> be quite reasonable because the reset controller is tightly embedded
> inside and exported from these clock subsystems. At least it can be found
> on infracfg and pericfg subsystem that both are really fundamental block
> lots of devices must depend on.
>
> commit 74cb0d6dde8 ("clk: mediatek: fixup test-building of MediaTek clock
> drivers") can let the build system looking into the directory where the
> clock drivers resides and then allow test-building the drivers.
>
> But the change also gives rise to certain incorrect behavior which is
> reset.c being built even not depending on either COMPILE_TEST or
> ARCH_MEDIATEK alternative dependency. To get rid of reset.c being built
> unexpectedly on the other platforms, it would be a good change that the
> file should be built depending on its own specific configuration rather
> than just on generic RESET_CONTROLLER one.
>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2018-01-10 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 8:14 [PATCH v2] clk: mediatek: adjust dependency of reset.c to avoid unexpectedly being built sean.wang
2018-01-05 8:14 ` sean.wang
2018-01-10 21:45 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110214521.GE28313@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=chen.zhong@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=jdelvare@suse.de \
--cc=kevin-cw.chen@mediatek.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sean.wang@mediatek.com \
--cc=shunli.wang@mediatek.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.