From: Stephen Boyd <sboyd@codeaurora.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
"Wangtao (Kevin, Kirin)" <kevin.wangtao@hisilicon.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
Michael Turquette <mturquette@baylibre.com>,
Kaihua Zhong <zhongkaihua@huawei.com>,
Ruyi Wang <wangruyi@huawei.com>,
Kai Zhao <zhaokai1@hisilicon.com>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH -next] clk: hisilicon: hi3660：Fix potential NULL dereference in hi3660_stub_clk_probe()
Date: Wed, 10 Jan 2018 14:48:20 -0800 [thread overview]
Message-ID: <20180110224820.GH28313@codeaurora.org> (raw)
In-Reply-To: <20180108042235.GA21618@leoy-ThinkPad-T440>
On 01/08, Leo Yan wrote:
>
> I verified Yongjun patch v2 for using devm_ioremap_resource(), just as
> Kevin mentioned after using devm_ioremap_resource() the kernel has
> memory mapping conflict between stub clock driver and mailbox driver.
>
> Following Masahiro suggestion, I changed the stub clock driver to use
> syscon & regmap to access the memory, I can confirm this can work
> well, you could review in below change.
>
> But this change should note two things, one thing is it is dependent on
> mailbox driver upstreaming, so I prefer we can commit one patch for this
> change along with mailbox driver patch set; the second thing is we
> need change DT binding document.
>
> If you have any better solution for this, also very welcome.
>
So I'll apply the original patch it sounds like.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-01-10 22:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 6:36 [PATCH -next] clk: hisilicon: hi3660：Fix potential NULL dereference in hi3660_stub_clk_probe() Wei Yongjun
2018-01-05 3:59 ` Masahiro Yamada
2018-01-05 8:40 ` Leo Yan
2018-01-05 8:54 ` weiyongjun (A)
2018-01-05 9:47 ` Wangtao (Kevin, Kirin)
2018-01-05 9:50 ` Masahiro Yamada
2018-01-05 10:47 ` Wangtao (Kevin, Kirin)
2018-01-08 4:22 ` Leo Yan
2018-01-10 22:48 ` Stephen Boyd [this message]
2018-01-17 7:58 ` Leo Yan
2018-01-05 9:04 ` [PATCH -next v2] clk: hisilicon: Using devm_ioremap_resource() instead of devm_ioremap() Wei Yongjun
2018-03-12 22:13 ` [PATCH -next] clk: hisilicon: hi3660：Fix potential NULL dereference in hi3660_stub_clk_probe() Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110224820.GH28313@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=kevin.wangtao@hisilicon.com \
--cc=leo.yan@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=wangruyi@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=yamada.masahiro@socionext.com \
--cc=zhaokai1@hisilicon.com \
--cc=zhongkaihua@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.