From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: RCU: Call touch_nmi_watchdog() while printing stall warnings
Date: Thu, 11 Jan 2018 09:45:08 +0900 [thread overview]
Message-ID: <20180111004508.GA3320@jagdpanzerIV> (raw)
In-Reply-To: <20180110145743.GD3668920@devbig577.frc2.facebook.com>
On (01/10/18 06:57), Tejun Heo wrote:
[..]
> > diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> > index 9960f8842b31..649c00a9af12 100644
> > --- a/kernel/workqueue.c
> > +++ b/kernel/workqueue.c
> > @@ -48,6 +48,7 @@
> > #include <linux/moduleparam.h>
> > #include <linux/uaccess.h>
> > #include <linux/sched/isolation.h>
> > +#include <linux/nmi.h>
> >
> > #include "workqueue_internal.h"
> >
> > @@ -4473,6 +4474,8 @@ void show_workqueue_state(void)
> > if (pwq->nr_active || !list_empty(&pwq->delayed_works))
> > show_pwq(pwq);
> > spin_unlock_irqrestore(&pwq->pool->lock, flags);
> > +
> > + touch_nmi_watchdog();
>
> Can you send a patch w/ signed-off-by adding touch_nmi_watchdog() to
> both outer loops in that function. Theoretically, we can have a lot
> of pools too.
thanks. will do.
-ss
next prev parent reply other threads:[~2018-01-11 0:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 3:52 Can RCU stall lead to hard lockups? Tejun Heo
2018-01-09 4:24 ` Paul E. McKenney
2018-01-09 14:11 ` Tejun Heo
2018-01-09 15:22 ` Paul E. McKenney
2018-01-09 18:47 ` [PATCH] RCU: Call touch_nmi_watchdog() while printing stall warnings Tejun Heo
2018-01-09 18:52 ` [PATCH trivial-v2] " Tejun Heo
2018-01-09 20:05 ` Paul E. McKenney
2018-01-10 5:34 ` Sergey Senozhatsky
2018-01-10 14:57 ` Tejun Heo
2018-01-11 0:45 ` Sergey Senozhatsky [this message]
2018-02-02 23:44 ` Can RCU stall lead to hard lockups? Serge E. Hallyn
2018-02-03 20:50 ` Paul E. McKenney
2018-02-07 2:33 ` Serge E. Hallyn
2018-02-07 2:53 ` Paul E. McKenney
2018-02-07 2:55 ` Serge E. Hallyn
2018-02-07 3:16 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111004508.GA3320@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.