All of lore.kernel.org
 help / color / mirror / Atom feed
From: <pkshih@realtek.com>
To: <kvalo@codeaurora.org>
Cc: <Larry.Finger@lwfinger.net>, <yhchuang@realtek.com>,
	<linux-wireless@vger.kernel.org>
Subject: [PATCH v2 03/10] rtlwifi: Add sta_statistics of mac80211's op, and set filled=0 by default
Date: Thu, 11 Jan 2018 15:09:25 +0800	[thread overview]
Message-ID: <20180111070932.9929-4-pkshih@realtek.com> (raw)
In-Reply-To: <20180111070932.9929-1-pkshih@realtek.com>

From: Ping-Ke Shih <pkshih@realtek.com>

When using iwconfig to check wifi status, wext uses 'static struct' of
sinfo to get station info so sinfo->filled will be persistent. Since the
commit 2b9a7e1bac24 ("mac80211: allow drivers to provide most station
statistics") assumes driver initializes sinfo->filled to declare supported
fields, without initialization it will report wrong info. This commit
simply set 'filled' to be zero simply, and left sinfo to be filled by
mac80211.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtlwifi/core.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
index a78b828f531a..ec639fa8095e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/core.c
+++ b/drivers/net/wireless/realtek/rtlwifi/core.c
@@ -992,6 +992,15 @@ static int _rtl_get_hal_qnum(u16 queue)
 	return qnum;
 }
 
+static void rtl_op_sta_statistics(struct ieee80211_hw *hw,
+				  struct ieee80211_vif *vif,
+				  struct ieee80211_sta *sta,
+				  struct station_info *sinfo)
+{
+	/* nothing filled by driver, so mac80211 will update all info */
+	sinfo->filled = 0;
+}
+
 /*
  *for mac80211 VO = 0, VI = 1, BE = 2, BK = 3
  *for rtl819x  BE = 0, BK = 1, VI = 2, VO = 3
@@ -1878,6 +1887,7 @@ const struct ieee80211_ops rtl_ops = {
 	.config = rtl_op_config,
 	.configure_filter = rtl_op_configure_filter,
 	.set_key = rtl_op_set_key,
+	.sta_statistics = rtl_op_sta_statistics,
 	.conf_tx = rtl_op_conf_tx,
 	.bss_info_changed = rtl_op_bss_info_changed,
 	.get_tsf = rtl_op_get_tsf,
-- 
2.15.1

  parent reply	other threads:[~2018-01-11  7:10 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  7:09 [PATCH v2 00/10] rtlwifi: fix some bugs and add btcoex functions pkshih
2018-01-11  7:09 ` [PATCH v2 01/10] rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS pkshih
2018-01-12 19:36   ` Larry Finger
2018-01-11  7:09 ` [PATCH v2 02/10] rtlwifi: fix scan channel 1 fail after IPS pkshih
2018-01-15 18:49   ` Larry Finger
2018-01-11  7:09 ` pkshih [this message]
2018-01-15 18:51   ` [PATCH v2 03/10] rtlwifi: Add sta_statistics of mac80211's op, and set filled=0 by default Larry Finger
2018-01-16 15:42   ` Kalle Valo
2018-01-16 22:06     ` Johannes Berg
2018-01-11  7:09 ` [PATCH v2 04/10] rtlwifi: unlink bss when un-association pkshih
2018-01-15 18:53   ` Larry Finger
2018-01-11  7:09 ` [PATCH v2 05/10] rtlwifi: enable mac80211 fast-tx support pkshih
2018-01-15 18:54   ` Larry Finger
2018-01-16 15:45   ` Kalle Valo
2018-01-16 20:12     ` Arend van Spriel
2018-01-16 22:24       ` Johannes Berg
2018-01-17  8:37         ` Arend van Spriel
2018-01-17  8:43           ` Johannes Berg
2018-01-18  9:05         ` Pkshih
2018-01-18 10:09           ` Johannes Berg
2018-01-19  1:39             ` Pkshih
2018-01-11  7:09 ` [PATCH v2 06/10] rtlwifi: Support A-MSDU in A-MPDU capability pkshih
2018-01-15 18:55   ` Larry Finger
2018-01-11  7:09 ` [PATCH v2 07/10] rtlwifi: btcoex: Add power_on_setting routine pkshih
2018-01-15 19:19   ` Larry Finger
2018-01-16  1:28     ` Pkshih
2018-01-11  7:09 ` [PATCH v2 08/10] rtlwifi: btcoex: Remove global variables from btcoex pkshih
2018-01-15 19:02   ` Larry Finger
2018-01-11  7:09 ` [PATCH v2 09/10] rtlwifi: btcoex: Add common function for qeurying BT information pkshih
2018-01-15 19:15   ` Larry Finger
2018-01-16  0:55     ` Pkshih
2018-01-16 15:52     ` Kalle Valo
2018-01-16 17:02       ` Larry Finger
2018-01-11  7:09 ` [PATCH v2 10/10] rtlwifi: btcoex: add rfe_type parameter to btcoex pkshih
2018-01-15 19:17   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180111070932.9929-4-pkshih@realtek.com \
    --to=pkshih@realtek.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.